RDKEMW-13117: Use IARM for PowerManager clients which uses PowerController ThunderClientLibrary#589
Conversation
There was a problem hiding this comment.
Pull request overview
This PR transitions the remotedebugger recipe from using WPEFramework PowerController ThunderClientLibrary to IARM for power management, as indicated by the title "RDKEMW-13117: Use IARM for PowerManager clients which uses PowerController ThunderClientLibrary". The remotedebugger recipe already has IARM dependencies (iarmbus, iarmmgrs) and IARMBUS support enabled, making this transition natural.
Changes:
- Commented out WPEFramework PowerController specific compilation flags (CFLAGS with include paths and -DPWRMGR_PLUGIN define, LDFLAGS with -lWPEFrameworkPowerController)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}" | ||
| RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}" |
There was a problem hiding this comment.
The conditional dependencies on wpeframework-clientlibraries are still present on lines 21-22, but the compilation flags that would actually use these dependencies (CFLAGS with -DPWRMGR_PLUGIN, include paths, and LDFLAGS with -lWPEFrameworkPowerController) have been commented out on lines 23-25. This creates an inconsistency where the dependencies will be added to DEPENDS and RDEPENDS when 'pwrmgr-plugin' is in DISTRO_FEATURES, but the code won't be compiled to use them. Either remove these conditional dependency lines as well, or uncomment the compilation flags.
| DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}" | |
| RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}" | |
| #DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}" | |
| #RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}" |
No description provided.