Skip to content

RDKEMW-13117: Use IARM for PowerManager clients which uses PowerController ThunderClientLibrary#589

Open
yuvaramachandran-gurusamy wants to merge 1 commit intotest/support-2p16p9_Testfrom
topic/RDKEMW-13117_2p16p9_Test
Open

RDKEMW-13117: Use IARM for PowerManager clients which uses PowerController ThunderClientLibrary#589
yuvaramachandran-gurusamy wants to merge 1 commit intotest/support-2p16p9_Testfrom
topic/RDKEMW-13117_2p16p9_Test

Conversation

@yuvaramachandran-gurusamy

No description provided.

Copilot AI review requested due to automatic review settings February 19, 2026 10:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions the remotedebugger recipe from using WPEFramework PowerController ThunderClientLibrary to IARM for power management, as indicated by the title "RDKEMW-13117: Use IARM for PowerManager clients which uses PowerController ThunderClientLibrary". The remotedebugger recipe already has IARM dependencies (iarmbus, iarmmgrs) and IARMBUS support enabled, making this transition natural.

Changes:

  • Commented out WPEFramework PowerController specific compilation flags (CFLAGS with include paths and -DPWRMGR_PLUGIN define, LDFLAGS with -lWPEFrameworkPowerController)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 21 to 22
DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}"
RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}"
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional dependencies on wpeframework-clientlibraries are still present on lines 21-22, but the compilation flags that would actually use these dependencies (CFLAGS with -DPWRMGR_PLUGIN, include paths, and LDFLAGS with -lWPEFrameworkPowerController) have been commented out on lines 23-25. This creates an inconsistency where the dependencies will be added to DEPENDS and RDEPENDS when 'pwrmgr-plugin' is in DISTRO_FEATURES, but the code won't be compiled to use them. Either remove these conditional dependency lines as well, or uncomment the compilation flags.

Suggested change
DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}"
RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}"
#DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', 'wpeframework-clientlibraries', '', d)}"
#RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pwrmgr-plugin', ' wpeframework-clientlibraries ', '', d)}"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants