Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Yocto recipe for commonutilities to point to a newer upstream git commit via SRCREV, ensuring builds pull the intended source revision.
Changes:
- Updated
SRCREVincommonutilities_git.bbto a new commit hash.
Comments suppressed due to low confidence (1)
recipes-common/utils/commonutilities_git.bb:6
- Changing SRCREV without also bumping PV/PR can result in packages being rebuilt from a different commit but keeping the same version string (PV-PR), which can prevent upgrades in feed-based deployments (e.g., opkg) and make it hard to trace which commit is running. Consider either bumping PR (or PV) with this SRCREV change, or switching PV to include the git revision (e.g., using SRCPV) if that matches this layer’s versioning approach.
SRCREV = "b2d9c111144c488ef0cb869cf1afe3718d1fd5ff"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
recipes-common/utils/commonutilities_git.bb:6
- SRCREV was updated but PV/PR stayed the same (PV="1.5.1", PR="r1"). If this layer publishes packages to a feed, consumers may not see an upgrade because the package version doesn’t change even though the source does. Consider bumping PR (or PV) alongside the SRCREV change so the resulting package version reflects the update.
SRCREV = "f0f78f04d77ea5c95dbdbc5093929861439ccf60"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
recipes-common/utils/commonutilities_git.bb:6
- SRCREV is being updated while PV (1.5.1) and PR (r1) remain unchanged. With a fixed PV/PR, downstream package feeds/upgrades can end up with different contents under the same version string; consider bumping PR (or PV) to ensure the produced package version changes when the source revision changes.
SRCREV = "dea382a65e68f6a3f1dfc137b8ad5bec2076b824"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
recipes-common/utils/commonutilities_git.bb:6
- SRCREV was updated but PV/PR are unchanged (PV is a fixed string and doesn’t include SRCPV). In Yocto package feeds this can produce a new build that has the same version as the previous one, preventing upgrades or causing conflicts. Consider bumping PR (or updating PV / using PV that incorporates SRCPV) when changing SRCREV.
SRCREV = "8fd1ccf4492109ae58289a3da829bcaabdb2506c"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
recipes-common/utils/commonutilities_git.bb:8
- SRCREV is being updated but PV/PR remain unchanged (PV is fixed at 1.5.1 and PR is r1). In Yocto package feeds, this can produce packages with the same version string but different contents, which can prevent upgrades and complicate traceability. Consider bumping PR (e.g., r2) or including git revision in PV (e.g., "+git${SRCPV}") so the produced package version changes when SRCREV changes.
SRCREV = "4c8c7358f3781990f12e9d7b3563db21538081cf"
SRC_URI = "${CMF_GITHUB_ROOT}/common_utilities;module=.;${CMF_GITHUB_SRC_URI_SUFFIX}"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.