Skip to content

RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#626

Open
tabbas651 wants to merge 1 commit intodevelopfrom
topic/RDKEMW-14121
Open

RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#626
tabbas651 wants to merge 1 commit intodevelopfrom
topic/RDKEMW-14121

Conversation

@tabbas651
Copy link
Contributor

Reason for change: Added forked version git hash id for testing
Test Procedure: please refer the ticket comments
Risks: Medium

Reason for change: Added forked version git hash id for testing
Test Procedure: please refer the ticket comments
Risks: Medium
Copilot AI review requested due to automatic review settings March 2, 2026 22:28
@tabbas651 tabbas651 requested review from a team as code owners March 2, 2026 22:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Yocto recipe for memcapture to fetch a different upstream revision/repository, apparently to validate changes for Mediatek platform support.

Changes:

  • Updated SRCREV to a new git commit hash.
  • Changed SRC_URI from the RDKCentral repository to a forked GitHub repository URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SRCREV = "0cf90e07af97b70fb1f253ebd0f71edd5a9b8225"
SRC_URI = "git://github.com/RDKCentral/MemCapture.git;branch=main;name=src;destsuffix=git"
SRCREV = "b796f1532d1863748e4bbe71c9feaada3f5cac50"
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe hardcodes a GitHub URL and omits the repo-wide GitHub URI helpers. Most recipes use CMF_GITHUB_ROOT + CMF_GITHUB_SRC_URI_SUFFIX (protocol/branch defaults) from conf/distro/include/rdk-versions.inc to keep fetch behavior consistent. Consider rewriting this SRC_URI to follow that pattern so protocol/branch handling stays centralized.

Suggested change
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
SRC_URI = "${CMF_GITHUB_ROOT}/tabbas651/MemCapture.git;name=src;destsuffix=git${CMF_GITHUB_SRC_URI_SUFFIX}"

Copilot uses AI. Check for mistakes.

SRCREV = "0cf90e07af97b70fb1f253ebd0f71edd5a9b8225"
SRC_URI = "git://github.com/RDKCentral/MemCapture.git;branch=main;name=src;destsuffix=git"
SRCREV = "b796f1532d1863748e4bbe71c9feaada3f5cac50"
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description indicate “Added Mediatek Platform support”, but this diff only changes SRCREV/SRC_URI to a forked hash for testing. Please either update the PR description/title to match the actual change, or include the Mediatek support changes in this PR and keep the recipe pointed at the official upstream.

Copilot uses AI. Check for mistakes.
SRCREV = "0cf90e07af97b70fb1f253ebd0f71edd5a9b8225"
SRC_URI = "git://github.com/RDKCentral/MemCapture.git;branch=main;name=src;destsuffix=git"
SRCREV = "b796f1532d1863748e4bbe71c9feaada3f5cac50"
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRC_URI now points to a personal fork (github.com/tabbas651). For a production Yocto recipe this is a supply-chain and availability risk (account deletion/force-push/private repo) and makes builds non-reproducible for others. Please switch back to an organization-owned upstream (e.g., rdkcentral/code.rdkcentral.com) and carry Mediatek changes as a patch/branch in the official repo instead of a personal fork.

Suggested change
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
SRC_URI = "git://github.com/rdkcentral/MemCapture.git;branch=main;name=src;destsuffix=git"

Copilot uses AI. Check for mistakes.
SRCREV = "0cf90e07af97b70fb1f253ebd0f71edd5a9b8225"
SRC_URI = "git://github.com/RDKCentral/MemCapture.git;branch=main;name=src;destsuffix=git"
SRCREV = "b796f1532d1863748e4bbe71c9feaada3f5cac50"
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the git:// protocol in SRC_URI fetches source code over an unencrypted, unauthenticated channel, allowing a network attacker between the build host and GitHub to tamper with the code being built. This could inject malicious changes into the memcapture binary without detection, compromising any systems that run it. Prefer a secure transport (for example, HTTPS with certificate validation) for fetching source repositories in the build.

Suggested change
SRC_URI = "git://github.com/tabbas651/MemCapture.git;branch=main;name=src;destsuffix=git"
SRC_URI = "git://github.com/tabbas651/MemCapture.git;protocol=https;branch=main;name=src;destsuffix=git"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants