Skip to content

gh #192 updated the tapo multi power switch changes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TB-1993 merged 2 commits into from
Nov 14, 2025
Merged

gh #192 updated the tapo multi power switch changes #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea0575
gh #192 updated the tapo multi power switch changes
Anbukannadhasan Nov 6, 2025
f8f7d9f
gh #192 updated the co pilot review suggestions
Anbukannadhasan Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 56 additions & 37 deletions framework/core/powerModules/tapoControl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import json
import re
import subprocess
import time

from framework.core.logModule import logModule
from framework.core.powerModules.abstractPowerModule import PowerModuleInterface
Expand All @@ -75,7 +74,7 @@ def __init__( self, log:logModule, ip:str, outlet:str = None, **kwargs ):
self.ip = ip
self._username = kwargs.get("username", None)
self._password = kwargs.get("password", None)
if outlet:
if outlet is not None:
self._outlet=str(outlet)
self._device_type = None
self._encryption_type = None
Expand Down Expand Up @@ -111,7 +110,7 @@ def _performCommand(self, command, json = False, append_args:list = []):
command_list.append("--encrypt-type")
command_list.append(self._encryption_type)
else:
if self._outlet:
if self._outlet is not None:
command_list.append("--type")
command_list.append("strip")
else:
Expand All @@ -133,16 +132,16 @@ def powerOff(self):
bool: True if the operation is successful, False otherwise.
"""
self._get_state()
if self.is_off:
if not self._is_on:
return True
if self._outlet:
if self._outlet is not None:
self._performCommand("off", append_args=["--index", str(self._outlet)])
else:
self._performCommand("off")
self._get_state()
if self.is_off == False:
if self._is_on:
self._log.error(" Power Off Failed")
return self.is_off
return not self._is_on

def powerOn(self):
"""
Expand All @@ -152,21 +151,33 @@ def powerOn(self):
bool: True if the operation is successful, False otherwise.
"""
self._get_state()
if self.is_on:
if self._is_on:
return True
if self._outlet:
if self._outlet is not None:
self._performCommand("on", append_args=["--index", str(self._outlet)])
self._performCommand("on")
else:
self._performCommand("on")
self._get_state()
if self.is_on == False:
if not self._is_on:
self._log.error(" Power On Failed")
return self.is_on
return self._is_on

def _get_state(self):
"""Get the state of the device.
"""
result = self._performCommand("state")
if self._outlet:
if self._outlet is not None:
# == Children ==
#
# == Smart Plug 1 (P304M) ==
# == Primary features ==
# State(state): True
if 'Children' in result: # smart extension plug with multiple outlets
all_states = re.findall(r"^\s*State\s*\(state\)\s*:\s*(True|False)\s*$",
result, flags=re.IGNORECASE | re.MULTILINE)
self._is_on = all_states[int(self._outlet)] == 'True'
self._log.debug(f"Slot state: {'ON' if self._is_on else 'OFF'}")
return
# We have a strip look at the status of the strip, and check the index and the device state
#Device state: ON
#== Plugs ==
Expand Down Expand Up @@ -233,6 +244,12 @@ def _discover_device(self):
self._device_type = info.get("mic_type", "UNKNOWN")
else:
self._device_type = "UNKNOWN"
elif result.get("get_child_device_list", {}).get('child_device_list', []):
child_devices = result.get("get_child_device_list", {}).get('child_device_list', [])
if len(child_devices) > int(self._outlet):
self._device_type = child_devices[int(self._outlet)].get("type", "UNKNOWN")
elif result.get('get_device_info'):
self._device_type = result.get("get_device_info").get("type", "UNKNOWN")
else:
self._device_type = "UNKNOWN"
self._encryption_type = self._get_encryption_type()
Expand All @@ -249,28 +266,30 @@ def _get_encryption_type(self):
return None

def getPowerLevel(self):
if self._outlet:
# TODO: implement this for a powerstrip
# result = self._performCommand("emeter",
# json=True,
# append_args=["--index", str(self._outlet)])
raise RuntimeError("Power monitoring is not yet supported for Tapo strips")
if self._outlet is not None:
args = [
"--module", 'energy', 'get_current_power',
"--index", self._outlet
]
else:
result = self._performCommand("emeter", json=True)

if not result:
raise ValueError("Received empty response from Tapo device for power monitoring")

try:
result = json.loads(result)
except json.JSONDecodeError as e:
raise ValueError(f"Failed to parse JSON from Tapo device response: {e}")

millewatt = result.get('power_mw')
if millewatt:
try:
power = int(millewatt) / 1000
return power
except:
raise ValueError(f"Invalid value for power_mw: {millewatt}")
raise KeyError("The dictionary returned by the Tapo device does not contain a valid 'power_mw' value.")
args = [
"--module", 'energy', 'get_current_power'
]
result = self._performCommand("command",
json=True,
append_args=args
)

if not result:
raise ValueError("Received empty response from Tapo device for power monitoring")

try:
result = json.loads(result)
except json.JSONDecodeError as e:
raise ValueError(f"Failed to parse JSON from Tapo device response: {e}")

watt = result.get("get_current_power", {}).get('current_power', None)
if watt is not None:
return watt

raise KeyError("The dictionary returned by the Tapo device does not contain a valid 'current_power' value.")
6 changes: 3 additions & 3 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jmespath==1.0.1
marshmallow==3.21.1
multidict==6.0.5
netifaces==0.11.0
numpy==1.26.4
numpy>=2.0.0,<2.3.0
opencv-python==4.9.0.80
outcome==1.3.0.post0
packaging==24.0
Expand All @@ -49,7 +49,7 @@ pyserial==3.5
PySocks==1.7.1
pytesseract==0.3.10
python-dateutil==2.9.0.post0
python-kasa==0.6.2.1
python-kasa==0.7.7
PyYAML==6.0.1
requests==2.31.0
requests-toolbelt==1.0.0
Expand All @@ -61,7 +61,7 @@ sortedcontainers==2.4.0
soupsieve==2.5
trio==0.25.0
trio-websocket==0.11.1
typing_extensions==4.10.0
typing_extensions==4.12.2
urllib3==1.26.18
wcwidth==0.2.14
wrapt==1.16.0
Expand Down