Skip to content

Conversation

@bhanucbp
Copy link
Contributor

  • Add virtual HDMI-CEC client
  • Add utcontroller class

- Add virtual HDMI-CEC client
- Add utcontroller class
@bhanucbp bhanucbp requested review from TB-1993 and zghp November 24, 2025 18:14
@bhanucbp bhanucbp self-assigned this Nov 24, 2025
Copilot AI review requested due to automatic review settings November 24, 2025 18:14
@bhanucbp bhanucbp added the enhancement New feature or request label Nov 24, 2025
@bhanucbp bhanucbp linked an issue Nov 24, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a virtual HDMI-CEC client by introducing the utPlaneController class for managing HTTP-based communication with a ut-controller service, and the virtualCECController class that implements the CEC interface for virtual CEC device simulation.

Key changes:

  • Added utPlaneController class to send YAML commands/configs to ut-controller via HTTP/curl
  • Added virtualCECController implementation with device network configuration loading and CEC message handling
  • Integrated virtual-cec-client support into the existing HDMICECController framework

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
framework/core/utPlaneController.py New controller class for HTTP-based communication with ut-controller service using curl commands
framework/core/hdmicecModules/virtualCECController.py New virtual CEC client implementation with SSH-based device control and YAML configuration management
framework/core/hdmicecModules/configuration/virtual_cec_print_device_network_configuration.yaml Configuration file for printing CEC device network information
framework/core/hdmicecModules/abstractCECController.py Whitespace cleanup (trailing space removed)
framework/core/hdmiCECController.py Integration of virtual-cec-client type with mock checkMessageReceived implementation
examples/configs/example_rack_config.yml Documentation updates with virtual-cec-client configuration example and whitespace cleanup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@zghp zghp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the copilot mentions, I can't see other changes that need to be done right now. please update the code according to the suggestions and then I can have a look at it again.

- Addressed review comments
- Addressed review comments
Copilot AI review requested due to automatic review settings November 26, 2025 14:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Addressed review comments
Copilot AI review requested due to automatic review settings November 27, 2025 13:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@kanjoe24 kanjoe24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@zghp zghp merged commit 3c02032 into develop Nov 28, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

Status: Resolved

Development

Successfully merging this pull request may close these issues.

Feature: Add virtual HDMI-CEC client

4 participants