-
Notifications
You must be signed in to change notification settings - Fork 2
gh#197: Add Virtual HDMI-CEC client #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bhanucbp
commented
Nov 24, 2025
- Add virtual HDMI-CEC client
- Add utcontroller class
- Add virtual HDMI-CEC client - Add utcontroller class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for a virtual HDMI-CEC client by introducing the utPlaneController class for managing HTTP-based communication with a ut-controller service, and the virtualCECController class that implements the CEC interface for virtual CEC device simulation.
Key changes:
- Added
utPlaneControllerclass to send YAML commands/configs to ut-controller via HTTP/curl - Added
virtualCECControllerimplementation with device network configuration loading and CEC message handling - Integrated virtual-cec-client support into the existing HDMICECController framework
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/core/utPlaneController.py | New controller class for HTTP-based communication with ut-controller service using curl commands |
| framework/core/hdmicecModules/virtualCECController.py | New virtual CEC client implementation with SSH-based device control and YAML configuration management |
| framework/core/hdmicecModules/configuration/virtual_cec_print_device_network_configuration.yaml | Configuration file for printing CEC device network information |
| framework/core/hdmicecModules/abstractCECController.py | Whitespace cleanup (trailing space removed) |
| framework/core/hdmiCECController.py | Integration of virtual-cec-client type with mock checkMessageReceived implementation |
| examples/configs/example_rack_config.yml | Documentation updates with virtual-cec-client configuration example and whitespace cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zghp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the copilot mentions, I can't see other changes that need to be done right now. please update the code according to the suggestions and then I can have a look at it again.
- Addressed review comments
- Addressed review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Addressed review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kanjoe24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved