Skip to content

Conversation

@TB-1993
Copy link
Contributor

@TB-1993 TB-1993 commented Jan 5, 2026

closes #201

Copilot AI review requested due to automatic review settings January 5, 2026 11:42
@TB-1993 TB-1993 requested a review from zghp January 5, 2026 11:42
@TB-1993 TB-1993 self-assigned this Jan 5, 2026
@TB-1993 TB-1993 added the bug Something isn't working label Jan 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a typo in the start() method of the HubClient class where the wrong variable name was being used. The function parameter is netbox_id, but the code was incorrectly referencing netbox_ip in two places within the method body.

  • Fixed variable name from netbox_ip to netbox_id to match the function parameter
  • Corrected both the conditional check and the filter operation to use the correct variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@TB-1993 TB-1993 merged commit ef115dd into develop Jan 8, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: RedRat Python RAFT file uses incorrect variable name network_ip instead of network_id, causing runtime error.

3 participants