rtmessage: fix resource cleanup order in rtConnection_CreateInternal#399
Closed
Copilot wants to merge 1 commit intofix/resource-leak-rtConnectionfrom
Closed
rtmessage: fix resource cleanup order in rtConnection_CreateInternal#399Copilot wants to merge 1 commit intofix/resource-leak-rtConnectionfrom
Copilot wants to merge 1 commit intofix/resource-leak-rtConnectionfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix coverity resource leak in rtConnection_CreateInternal
rtmessage: fix resource cleanup order in rtConnection_CreateInternal
Nov 29, 2025
|
Thank you @Copilot for creating this auto-fix PR! However, this issue has already been addressed. The cleanup order was fixed in commit 8165c75 (pushed at 20:32 UTC), which reordered the cleanup to match the existing pattern at lines 770-773. Since the fix is already in PR #398, this sub-PR is no longer needed. Closing as duplicate. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed cleanup order inconsistency in error paths when buffer allocations fail. The original fix destroyed synchronization primitives in a different order than the existing cleanup function.
Changes
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.