gh #164 Update description of dsHdmiInGetStatus and dsHdmiInSelectPort #165
Conversation
Deploy cla action
srinivasgtl
moved this from In Progress
to Review Requested
in HAL Interface & Test Suit - Upgrades
include/dsHdmiIn.h
Outdated
| * Also, if thT port has an active connection, it should update isPresented to true as well. | ||
| * | ||
| * Also, if the port has an active connection, it should update isPresented to true as well. | ||
| * These Changes are applied asynchronously in a separate thread, and will be communicated through the |
There was a problem hiding this comment.
This statement shows that we are giving the implementation part rather than the specification. Can we make it like what we wanted from this function.
There was a problem hiding this comment.
Updated as per the comments.
New lines:
* Also, if the port has an active connection, it should update isPresented to true as well.
* Any change in the variable - 'dsHdmiInSignalStatus_t' will be communicated via the 'dsHdmiInStatusChangeCB_t' callback.
include/dsCompositeIn.h
Outdated
| * | ||
| * @note When a port is selected that port should be set as activePort in ::dsCompositeInStatus_t. | ||
| * Also, if there is a signal (ie isPortConnected[that port ID] is true), once active, isPresented should be set to true as well. | ||
| * These Changes are applied asynchronously in a separate thread, and will be communicated through the |
There was a problem hiding this comment.
Provide what we need from this API rather than how the implementation is considered.
There was a problem hiding this comment.
Updated as per the comments.
New lines:
* Any change in the variable - 'dsCompositeInStatus_t' will be communicated via the 'dsCompositeInStatusChangeCB_t' callback.
include/dsCompositeIn.h
Outdated
| * | ||
| * @pre dsCompositeInInit() should be called before calling this API. | ||
| * @pre dsCompositeInInit() should be called before calling this API. The Composite input port status is updated asynchronously via | ||
| * 'dsCompositeInStatusChangeCB_t' callback whenever a change is detected. |
There was a problem hiding this comment.
Can we provide what change is considered here? may be point to the structure dsCompInSignalStatus_t if we are considering these changes as part of this requirement.
There was a problem hiding this comment.
Updated as per the comments.
New lines:
* @pre dsCompositeInInit() should be called before calling this API.
* After every operation, that may change 'dsCompositeInStatus_t',should wait until the
* 'dsCompositeInStatusChangeCB_t' callback is received.
include/dsHdmiIn.h
Outdated
| * | ||
| * @pre dsHdmiInInit() must be called before calling this API. | ||
| * @pre dsHdmiInInit() must be called before calling this API. The HDMI input port status is updated asynchronously via | ||
| * 'dsHdmiInStatusChangeCB_t' callback whenever a change is detected. |
There was a problem hiding this comment.
The change is still a bit unclear, even on the callback description. Can you discuss with the team and suggest what changes are really considered here?
There was a problem hiding this comment.
Updated as per the comments.
New lines:
* After every operation, that may change 'dsHdmiInStatus_t',should wait until the
* 'dsHdmiInStatusChangeCB_t' callback is received.
Dhivyailangovan
dismissed stale reviews from thanushreevani and kanjoe24
via
a83fb0e
|
@Dhivyailangovan , always create PR against develop branch. I have now done the change for you, however you will need to resolve the conflicts now. |
|
Also, you have added Composite header files as well. Is this a new issue? If yes, can you raise a new ticket for composite and attach this PR to that as well or update it in the task ticket here(#164) Can you also rename the PR, so that it has github id and not jira id please |
Need to update the description of dsHdmiInGetStatus and dsHdmiInSelectPort to explain below points
activePort and isPresented will be updated asynchronously in a separate thread, and will be communicated through the 'hdmiInStatusChangeCB' callback.