Skip to content

Conversation

@kanjoe24
Copy link
Contributor

@kanjoe24 kanjoe24 commented Jan 6, 2026

Create release tag 6.0.1

lijokdevasia and others added 5 commits May 23, 2025 16:13
Merge tag '6.0.0' into develop
- Added dsVIDEO_FRAMERATE_59 for integer 59Hz frame rate
- Added dsVIDEO_FRAMERATE_23 for integer 23Hz frame rate

Issue#179
…erates

gh#179: Add dsVIDEO_FRAMERATE_59 and dsVIDEO_FRAMERATE_23 enums
Copilot AI review requested due to automatic review settings January 6, 2026 14:36
@github-actions
Copy link

github-actions bot commented Jan 6, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


3 out of 4 committers have signed the CLA.
✅ (lijokdevasia)[https://github.com/lijokdevasia]
✅ (rdkcmf-jenkins)[https://github.com/rdkcmf-jenkins]
✅ (Alan-Ryan)[https://github.com/Alan-Ryan]
@ljenchik
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request creates release tag 6.0.1, introducing new video frame rate support and adding CLA workflow automation.

  • Adds two new video frame rate enum values: 59 fps and 23 fps
  • Introduces GitHub Actions workflow for automated CLA signature verification

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
include/dsAVDTypes.h Adds dsVIDEO_FRAMERATE_59 and dsVIDEO_FRAMERATE_23 enum values to support additional frame rates
.github/workflows/cla.yml Adds new GitHub Actions workflow for automated Contributor License Agreement (CLA) verification on pull requests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +520 to +521
dsVIDEO_FRAMERATE_59, ///< Played at 59 frames per second
dsVIDEO_FRAMERATE_23, ///< Played at 23 frames per second
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new frame rate enums dsVIDEO_FRAMERATE_59 and dsVIDEO_FRAMERATE_23 are placed at the end of the enum before dsVIDEO_FRAMERATE_MAX, which breaks the logical ordering pattern. The existing enum follows an ascending order (24, 25, 30, 60, etc.). These new values should be inserted in their proper numeric positions: dsVIDEO_FRAMERATE_23 should be placed right after dsVIDEO_FRAMERATE_UNKNOWN (before dsVIDEO_FRAMERATE_24), and dsVIDEO_FRAMERATE_59 should be placed between dsVIDEO_FRAMERATE_50 and dsVIDEO_FRAMERATE_60. This placement also creates confusion because dsVIDEO_FRAMERATE_23 and dsVIDEO_FRAMERATE_24 are very similar (and 23 vs 23.98), as are dsVIDEO_FRAMERATE_59, dsVIDEO_FRAMERATE_59dot94, and dsVIDEO_FRAMERATE_60.

Copilot uses AI. Check for mistakes.
Comment on lines +520 to +521
dsVIDEO_FRAMERATE_59, ///< Played at 59 frames per second
dsVIDEO_FRAMERATE_23, ///< Played at 23 frames per second
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new enum values in the middle of an existing enum (by appending them before the MAX sentinel) is a breaking API change. Code that uses switch statements without default cases or relies on the numeric values of subsequent enums will break. Additionally, serialized data or configuration files that store enum values as integers will be misinterpreted. If these frame rates are truly needed, they should either be added at the end in a new major version, or the existing enum should be deprecated and a new versioned enum should be created.

Suggested change
dsVIDEO_FRAMERATE_59, ///< Played at 59 frames per second
dsVIDEO_FRAMERATE_23, ///< Played at 23 frames per second

Copilot uses AI. Check for mistakes.
@kanjoe24 kanjoe24 closed this Jan 6, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants