Adding changes to copy openssl and curl libraries to build/bin #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanjoe24
commented
Jun 11, 2025
| git checkout ${UT_CONTROL_PROJECT_VERSION} # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} | ||
| #git checkout ${UT_CONTROL_PROJECT_VERSION} # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} | ||
| git checkout feature/gh79-ut-control-reduce-size # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} | ||
| # Note: The above line can be modified by release test scripts to checkout a specific version or branch |
Contributor
Author
There was a problem hiding this comment.
This change needs to be reverted before final approval.
…ntral/ut-core into feature/ut-core-reduce-size-helper
Ulrond
reviewed
Jun 12, 2025
| @make test VARIANT=${VARIANT} | ||
| @cp -r $(UT_CONTROL)/build/$(TARGET)/lib/libut_control.* $(LIB_DIR) $(BIN_DIR) | ||
| @${ECHOE} ${GREEN}ut-control LIB Copied to [${BIN_DIR}]${NC} | ||
| @if [ -d "$(UT_CONTROL)/build/$(TARGET)/curl" ]; then \ |
Contributor
There was a problem hiding this comment.
ok that's not clear..
why has ut-core any knowledge curl is being used? that library is something that's provided by ut-control has nothitng todo with ut-core?
Ulrond
reviewed
Jun 12, 2025
| @if [ -d "$(UT_CONTROL)/build/$(TARGET)/curl" ]; then \ | ||
| cp -r $(UT_CONTROL)/build/$(TARGET)/curl/lib/libcurl.so* $(LIB_DIR) $(BIN_DIR); \ | ||
| fi | ||
| @if [ -d "$(UT_CONTROL)/build/$(TARGET)/openssl" ]; then \ |
Contributor
There was a problem hiding this comment.
makes no-sense, ut-core has no reason to know about openssl surely?
Ulrond
requested changes
Jun 12, 2025
| pushd ${UT_CONTROL_LIB_DIR} > /dev/null | ||
| git checkout ${UT_CONTROL_PROJECT_VERSION} # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} | ||
| #git checkout ${UT_CONTROL_PROJECT_VERSION} # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} | ||
| git checkout feature/gh79-ut-control-reduce-size # MARKER: Version=${UT_CONTROL_PROJECT_VERSION} |
Contributor
There was a problem hiding this comment.
you need to revert this one.
github-project-automation
bot
moved this from Todo
to Changes Requested
in UT-Core Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is helper for ut-control PR : rdkcentral/ut-control#80
It focusses on copying openssl and curl libraries to build folder.