RDKB-62412 LAN SSH dropbear allows wan SSH#191
Open
umasankar098 wants to merge 7 commits intordkcentral:developfrom
Open
RDKB-62412 LAN SSH dropbear allows wan SSH#191umasankar098 wants to merge 7 commits intordkcentral:developfrom
umasankar098 wants to merge 7 commits intordkcentral:developfrom
Conversation
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
guto86
previously approved these changes
Feb 18, 2026
Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
snayak002c
requested changes
Feb 27, 2026
| static int do_block_lan_access_to_wan_ssh(FILE *fp) | ||
| { | ||
| FIREWALL_DEBUG("Entering do_block_lan_access_to_wan_ssh\n"); | ||
| fprintf(fp, "-I INPUT 1 -i brlan0 -d %s -p tcp --dport 10022 -j REJECT\n", current_wan_ipaddr); |
Contributor
There was a problem hiding this comment.
is 10022 a hard coded ssh port in sky devices? , is it a generic issue or seen only in sky devices?
Also let's not hard code brlan0 interface name , use lan_ifname for private lan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.