RDKB-63303, RDKB-63414 : Move RdkLogger Scripts to Cron#245
RDKB-63303, RDKB-63414 : Move RdkLogger Scripts to Cron#245snayak002c merged 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to enable rdklogger scripts to run as cron jobs instead of background processes when the cron feature is enabled, as part of tickets RDKB-63303 and RDKB-63414. However, the PR only adds the configuration flag RdkbLogCronEnable to two system defaults files without including the implementation that actually uses this flag.
Changes:
- Added
RdkbLogCronEnable=trueflag to system_defaults_bci - Added
RdkbLogCronEnable=trueflag to system_defaults_arm
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/scripts/init/defaults/system_defaults_bci | Adds RdkbLogCronEnable configuration flag set to true by default |
| source/scripts/init/defaults/system_defaults_arm | Adds RdkbLogCronEnable configuration flag set to true by default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled. Test Procedure: Check scripts are running in crontab when the cron is enabled. Priority: P1 Risks: None Signed-off-by: KavyaChowdahalli_Suresh@comcast.com
ksures101
force-pushed
the
feature/RDKB-63414
branch
from
51d497e to
e96bd24
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #RdkLogger Cron - RFC flag is enabled by default | ||
| $RdkbLogCronEnable=true |
There was a problem hiding this comment.
The new RdkbLogCronEnable syscfg flag is defined here with a default value of true, but it is never read or consumed anywhere in the codebase. The corresponding logic to read this flag via syscfg get RdkbLogCronEnable and conditionally register the rdklogger scripts as cron jobs in service_crond.sh is missing. Without a consumer, this default value definition has no effect and the behavior described in the PR (running rdklogger scripts as cron jobs when cron is enabled) will not be implemented.
| #RdkLogger Cron - RFC flag is enabled by default | |
| $RdkbLogCronEnable=true |
Reason for change: Running the rdklogger scripts as cron jobs instead of background processes when the cron is enabled and running as normal background process when the cron is disabled.
Test Procedure: Check scripts are running in crontab when the cron is enabled.
Priority: P1
Risks: None
Signed-off-by: KavyaChowdahalli_Suresh@comcast.com