RDKB-63599:Private LAN traffic on/off handling #247
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -12925,7 +12925,23 @@ static int prepare_subtables(FILE *raw_fp, FILE *mangle_fp, FILE *nat_fp, FILE * | |||||||||||||||||||||||||||||||||||||||
| #endif | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
| /* | ||||||||||||||||||||||||||||||||||||||||
| * Check if LAN to WAN forwarding is enabled | ||||||||||||||||||||||||||||||||||||||||
| */ | ||||||||||||||||||||||||||||||||||||||||
| char cEnabled[8] = {0}; | ||||||||||||||||||||||||||||||||||||||||
| sysevent_get(sysevent_fd, sysevent_token, "lan_wan_forwarding_enabled", cEnabled, sizeof(cEnabled)); | ||||||||||||||||||||||||||||||||||||||||
| if ('\0' != cEnabled[0]) | ||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||
| if('\0' == lan_ifname[0]) | ||||||||||||||||||||||||||||||||||||||||
| snprintf(lan_ifname, sizeof(lan_ifname), "brlan0"); | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
| int iEnabled = atoi(cEnabled); | ||||||||||||||||||||||||||||||||||||||||
| if (0 == iEnabled) | ||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||
| fprintf(filter_fp, "-A lan2wan -i %s -j DROP\n", lan_ifname); | ||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The DROP rule is limited to
Suggested change
Contributor
Author
There was a problem hiding this comment. NOT ADDRESSED. We wan't block only private LAN if the wifi link status is non serviceable.
Comment on lines
+12935
to
+12941
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. NOT ADDRESSED. We don't want to touch the previous implementation. |
||||||||||||||||||||||||||||||||||||||||
| FIREWALL_DEBUG("LAN to WAN forwarding disabled, dropping all traffic from LAN to WAN\n"); | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
| /*********************** | ||||||||||||||||||||||||||||||||||||||||
| * set lan to wan subrule by order | ||||||||||||||||||||||||||||||||||||||||
| * *********************/ | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atoi(cEnabled)treats any non-numeric non-empty value (e.g., "true"/"false") as 0, which would disable forwarding unexpectedly. This file usually treats sysevent/syscfg boolean flags as enabled unless the value is empty or exactly "0" (e.g.,ciscoconnect_guest_enable,lanhost_tracking_enabled). Consider parsing this flag the same way (explicitly check for "0") or validate that the value is strictly "0"/"1" before usingatoi.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOT ADDRESSED.
we are only setting the lan_wan_forwarding_enabled as "0" or "1"