Set default MTU to 1500 for MACVLAN interface during creation#32
Merged
S-Parthiban-Selvaraj merged 1 commit intofeature/iproute-bridgefrom Feb 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR sets the default MTU (Maximum Transmission Unit) to 1500 for MACVLAN interfaces during their creation to ensure consistent network configuration.
Changes:
- Added MTU configuration step before bringing up the MACVLAN interface
- Included trace logging to document the MTU setting operation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Set MTU to default 1500 | ||
| CcspTraceInfo(("%s-%d: Setting MTU to 1500 for MACVLAN interface %s\n", | ||
| __FUNCTION__, __LINE__, pEntry->Name)); | ||
| v_secure_system("ip link set %s mtu 1500", pEntry->Name); |
There was a problem hiding this comment.
The MTU value 1500 is a magic number. Consider defining it as a named constant (e.g., #define DEFAULT_MACVLAN_MTU 1500) at the top of the file or in a header to improve maintainability and make it easier to update if needed.
guto86
approved these changes
Feb 18, 2026
S-Parthiban-Selvaraj
merged commit 37e501e
into
feature/iproute-bridge
6 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.