Conversation
…figuration and update TelcoVoiceManager for VOIP, VOICE, and MTA interfaces
S-Parthiban-Selvaraj
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug related to voice virtual interface conflicts by extending support beyond VOIP interfaces to also include VOICE and MTA interfaces. The core change introduces a new helper function WanMgr_IsVoiceInterface() to centralize the identification of voice-related interfaces and applies special handling for these interfaces throughout the WAN state machine.
Changes:
- Introduced
WanMgr_IsVoiceInterface()static inline helper function to identify voice interfaces (VOIP, VOICE, MTA) - Voice interfaces now skip system-level IPv4/IPv6 configuration (DNS, firewall, sysevents) and only perform address management
- Removed platform-specific DT_WAN_Manager_Enable conditional code blocks and replaced with unified voice interface handling
- Added .gitignore file with standard autotools-generated files and build artifacts
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| source/WanManager/wanmgr_interface_sm.h | Added static inline WanMgr_IsVoiceInterface() helper function to check if interface is VOIP, VOICE, or MTA |
| source/WanManager/wanmgr_interface_sm.c | Updated voice interface handling logic throughout state transitions - early returns in IPv4/IPv6 up/down transitions for voice interfaces, skipping system configuration in setup/teardown functions, and updated updateInterfaceToVoiceManager() to use new helper |
| source/WanManager/wanmgr_dhcpv6_apis.c | Added early return in setUpLanPrefixIPv6() to skip LAN prefix configuration for voice interfaces |
| source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c | Added include for wanmgr_interface_sm.h and skip WAN status updates for voice interfaces in Update_Interface_Status() |
| .gitignore | Added standard autotools-generated files and build artifacts to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LakshminarayananShenbagaraj
approved these changes
Feb 26, 2026
guto86
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR fixes a bug related to voice virtual interface conflicts by extending support beyond VOIP interfaces to also include VOICE and MTA interfaces. The core change introduces a new helper function WanMgr_IsVoiceInterface() to centralize the identification of voice-related interfaces and applies special handling for these interfaces throughout the WAN state machine.
Changes:
Introduced WanMgr_IsVoiceInterface() static inline helper function to identify voice interfaces (VOIP, VOICE, MTA)
Voice interfaces now skip system-level IPv4/IPv6 configuration (DNS, firewall, sysevents) and only perform address management
Removed platform-specific DT_WAN_Manager_Enable conditional code blocks and replaced with unified voice interface handling
Added .gitignore file with standard autotools-generated files and build artifacts