Skip to content

RDKB-62863: WiFi ready page is missing in captive portal #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar464 wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −3
Open

RDKB-62863: WiFi ready page is missing in captive portal #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/Styles/xb3/jst/captiveportal.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?%
/*
If not stated otherwise in this file or this component's Licenses.txt file the

Check failure on line 3 in source/Styles/xb3/jst/captiveportal.jst

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'source/Styles/xb3/jst/captiveportal.jst' (Match: rdkb/devices/rdkbemu/rdkbemu_xb3/rdkb/devices/rdkbemu/rdkbemu_xb3/1, 1314 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/devices/rdkbemu/rdkbemu_xb3/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: components/ccsp/webui/source/Styles/xb3/code/captiveportal.php)

Check failure on line 3 in source/Styles/xb3/jst/captiveportal.jst

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'source/Styles/xb3/jst/captiveportal.jst' (Match: rdkb/components/opensource/ccsp/webui/rdkb/components/opensource/ccsp/webui/1, 1309 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/opensource/ccsp/webui/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: source/Styles/xb3/code/captiveportal.php)

Check failure on line 3 in source/Styles/xb3/jst/captiveportal.jst

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'MIT' license found in local file 'source/Styles/xb3/jst/captiveportal.jst' (Match: rdkb/components/opensource/ccsp/webui/rdkb/components/opensource/ccsp/webui/1901, 1327 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/opensource/ccsp/webui/+archive/rdk-dev-1901.tar.gz, file: source/Styles/xb3/code/captiveportal.php)

Check failure on line 3 in source/Styles/xb3/jst/captiveportal.jst

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'MIT' license found in local file 'source/Styles/xb3/jst/captiveportal.jst' (Match: rdkb/components/opensource/ccsp/webui/rdkb/components/opensource/ccsp/webui/1907, 1332 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/opensource/ccsp/webui/+archive/RDK-DEV-1907.tar.gz, file: source/Styles/xb3/code/captiveportal.php)
following copyright and licenses apply:

Copyright 2018 RDK Management
Expand Down Expand Up @@ -367,9 +367,6 @@
location.href="index.jst";
}, 10000);
}
if(connectionType != "WiFi"){
setTimeout(function(){ goToReady(); }, 25000);
}
},
error: function(xhr, status, error) {
// Handle error
Expand All @@ -388,6 +385,9 @@
});
}
postConfig();
if(connectionType != "WiFi"){
setTimeout(function(){ goToReady(); }, 25000);
}
Comment on lines +388 to +390
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setTimeout now starts immediately when saveConfig() is called, rather than after AJAX success. This means goToReady() will execute after 25 seconds regardless of whether the configuration was successfully saved. If the AJAX request is retrying (up to 3 retries with 3-second delays each, potentially taking 9+ seconds) or fails after all retries, the ready page will still be shown, potentially before the configuration is actually saved. This could mislead users into thinking their configuration was saved when it may not have been. Consider tracking AJAX completion status and only showing the ready page after successful save, or add a fallback UI state for when configuration save fails.

Copilot uses AI. Check for mistakes.
}
var NameTimeout, PasswordTimeout, Name5Timeout, Password5Timeout, phoneNumberTimeout, agreementTimeout;
function messageHandler(target, topMessage, bottomMessage){
Expand Down
Loading