RDKB-63135, RDKB-63664 : Handle Security Edge feature for business#12
RDKB-63135, RDKB-63664 : Handle Security Edge feature for business#12
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Security Edge feature in business mode for ONESTACK products. The changes make DNSSecEnable and MultiProfileXDNS features conditional based on device mode - they work only in business mode when ONESTACK_PRODUCT_REQ is defined, while maintaining backward compatibility for CBR products.
Changes:
- Added configure option and build system support for ONESTACK products with devicemode library dependency
- Modified XDNS functionality to check device mode (business vs residential) when ONESTACK_PRODUCT_REQ is defined
- Replaced ReplaceDnsmasqConfEntry with RemoveDnsmasqConfEntry in DNSMappingTable_DelEntry for cleaner deletion logic
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| configure.ac | Added --enable-onestacksupport configuration option |
| source/dmlxdns/Makefile.am | Added devicemode library dependency and include path for ONESTACK builds |
| source/dmlxdns/cosa_xdns_apis.h | Added conditional include for devicemode.h and declared RemoveDnsmasqConfEntry function |
| source/dmlxdns/cosa_xdns_apis.c | Implemented RemoveDnsmasqConfEntry function and added business mode checks for Multi Profile XDNS feature |
| source/dmlxdns/cosa_xdns_dml.c | Added business mode conditional logic for DNSSecEnable parameter get/set operations and improved logging |
| source/dmlxdns/cosa_xdns_webconfig_api.c | Added business mode checks for XDNS configuration and DNS IP handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Handle Security Edge feature for business
Test Procedure:
Functionality of the following DMLs need to be tested:
Above mentioned DML parameters SHOULD work only if the devicemode is business.
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com