Updated ReplaceIRVar.cpp

[ayush-qubit]

No description provided.

[reSHARMA]

Do not use hasName; I think you are using hasName to check if it a variable or a constant? if yes, prefer checking if it is ConstantInt, like we did in the StoreInst.

[ayush-qubit]

I have done this with the help of llvm::Constant

[reSHARMA]

Yes, that will be great. Though, hasName will also work fine but it will add an explicit dependency to run instnamer or something instnamer like to get it working.

[reSHARMA]

Can this be written as:

  if (!llvm::isa<llvm::ConstantInt>(ValOp)) return TokenVec;      

  if (llvm::isa<llvm::ConstantPointerNull>(ValOp))
    TokenVec.push_back(this->getTokenWrapper()->getToken("NULL",nullptr));
  else
    TokenVec.push_back(this->getTokenWrapper()->getToken(ValOp));

[ayush-qubit]

I think you are trying to say

if (llvm::isa<llvm::ConstantInt>(ValOp)) return TokenVec;

if (llvm::isa<llvm::ConstantPointerNull>(ValOp))
TokenVec.push_back(this->getTokenWrapper()->getToken("NULL",nullptr));
else
TokenVec.push_back(this->getTokenWrapper()->getToken(ValOp));

And if it is then I have done this. Can I do this more general way like instead of using llvm::ConstantInt that can use only for integer constant we can use llvm::Constant which is more general way to say constant because constant can be float or double also.

[reSHARMA]

Yes, please :)

[reSHARMA]

I just realized that there can be other places where ConstantInt is used and it will fail with floats and doubles (thanks for pointing that out). Can you please create a github issue for that?

[reSHARMA]

.github has some action config and can not be put inside .gitignore.
Why do you need to add your gitignore to the PR?

[ayush-qubit]

I will remove .vscode and .github but at the time of pushing code my build folder is also pushing to remove my build folder I put it in .gitignore.

[reSHARMA]

How do you add files to commit? Do you do git add . or git commit -m, is yes, then try only adding the files that you want to be present in the commit.
For example, if you only want files inside lib and include to be in the commit then do git add lib/ include/

[ayush-qubit]

I have removed .gitignore

[reSHARMA]

This PR had changes for ReplaceIRVar, null token, and Phi node. Added some inline comments.