Port to Xunit #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Arkatufus wants to merge 58 commits into reactive-streams:master from Arkatufus:Update_to_Xunit

Arkatufus commented Aug 21, 2020 •

edited

Loading

Related to #45

Port NUnit to Xunit
Update build framework target from net45 to net452 and netstandard2.0

Arkatufus added 9 commits

August 21, 2020 19:44


          Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]

a38abc3


          Replace IgnoreException with SkipException

14ecb1d


          Replace Assert.Ignore with TckAssert.Skip and Assert.Fail with …

e2c1ae3

…`TckAssert.Fail`


          replace Assert functions to the equivalent version in Xunit

6e56e66


          Add Assert.Fail and Assert.Ignore support

56e9f3e


          Remove TextFixtureAttribute

08db990


          Add ITestOutputHelper support

ce6f42e


          Fix OptionalActivePublisherTest, it was eating all exceptions

72e080b


          Turn on netcoreapp3.1 testing

d484a57

Aaronontheweb commented Aug 21, 2020

Did you get a chance to see this comment by @marcpiechura from last year?

Author

Arkatufus commented Aug 21, 2020

Yes, that is possible to do in Xunit now

Arkatufus commented

View reviewed changes

src/tck/Reactive.Streams.TCK/Reactive.Streams.TCK.csproj

    
                <ItemGroup>

                  <PackageReference Include="NUnit" Version="3.7.1" />

                  <PackageReference Include="xunit" Version="2.4.1" />

                  <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />

Author

Arkatufus Aug 21, 2020 •

edited

Loading

This is a small helper package that lets us skip Xunit tests programatically by throwing SkipException

Arkatufus commented

View reviewed changes

src/tck/Reactive.Streams.TCK/SubscriberBlackboxVerification.cs

    
                              var element = default(T);

                              if(element != null)

                                  throw new IgnoreException("Can't verify behavior for value types");

                                  throw new SkipException("Can't verify behavior for value types");

Author

Arkatufus Aug 21, 2020

IgnoreException is replaced with SkipException

Arkatufus commented

View reviewed changes

src/tck/Reactive.Streams.TCK/Support/TckAssert.cs

    
              namespace Reactive.Streams.TCK.Support

              {

                  public static class TckAssert

Author

Arkatufus Aug 21, 2020

This static class is added to add Assert.Ignore (renamed to Skip) and Assert.Fail convenience static methods

Arkatufus and others added 16 commits

August 22, 2020 00:37


          Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args

1c4a538


          Merge branch 'master' into Update_to_Xunit

feb6247

# Conflicts:
#	src/examples/Reactive.Streams.Example.Unicast.Tests/SyncSubscriberTest.cs
#	src/examples/Reactive.Streams.Example.Unicast.Tests/SyncSubscriberWhiteboxTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/EmptyLazyPublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/IdentityProcessorVerificationTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/RangePublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SingleElementPublisherTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SubscriberBlackboxVerificationTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/Support/TCKVerificationSupport.cs
#	src/tck/Reactive.Streams.TCK.Tests/SyncTriggeredDemandSubscriberTest.cs
#	src/tck/Reactive.Streams.TCK.Tests/SyncTriggeredDemandSubscriberWhiteboxTest.cs


          Update framework targets and package versions

d9b05e3


          Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]

3e2e02f

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Replace IgnoreException with SkipException

2c21b07

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Replace Assert.Ignore with TckAssert.Skip and Assert.Fail with …

4c56cd0

…`TckAssert.Fail`

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          replace Assert functions to the equivalent version in Xunit

9fa653e

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add Assert.Fail and Assert.Ignore support

a6cb650

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Remove TextFixtureAttribute

5b50b7b

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add ITestOutputHelper support

ab53717

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Fix OptionalActivePublisherTest, it was eating all exceptions

49fd87e

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Turn on netcoreapp3.1 testing

044a695

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args

3a7436a

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Added me to relicensing file

3a85e83

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Signed relicensing doc

de965e7

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update Relicensing.txt

a5466f9

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>

akarnokd and others added 29 commits

May 18, 2021 00:11


          Fix missing Cancel() in tests that don't consume the entire source (#32)

abd4803

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update CopyrightWaivers.txt

c0225ec

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Skip §2.13 for value types (#34)

83730c7

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          fail if timeout is reached

d45bfa5

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          1.0.0 stable release (#28)

2b34b05

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          bump version

36ebf21

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add the 'I' prefix to component names

5d687fc

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update AsyncSubscriber.cs

d8964c0

Subscritpion to Subscription

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Added xml documentation (#42)

dac6326

* added xml documentation

* Updated NUnit runner

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Preparing for relicensing to MIT-0

a819a0e

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update Relicensing.txt

785397d

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]

b68530b

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Replace IgnoreException with SkipException

fbf7f35

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Replace Assert.Ignore with TckAssert.Skip and Assert.Fail with …

39d5b7b

…`TckAssert.Fail`

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          replace Assert functions to the equivalent version in Xunit

463a68c

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add Assert.Fail and Assert.Ignore support

380a841

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Remove TextFixtureAttribute

f43349c

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add ITestOutputHelper support

7fd7136

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Fix OptionalActivePublisherTest, it was eating all exceptions

5ff3cba

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Turn on netcoreapp3.1 testing

bc73d6b

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update build script to dotnet 3.1.105 LTS, add RunTestsDotNet build args

79008d1

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Added me to relicensing file

07b7f26

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Signed relicensing doc

b9fb096

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update Relicensing.txt

5ec79c5

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Port NUnit to XUnit, update target frameworks to netstandard2.0 and n…

2ff6255

…et461, update nuget package versions

Author:    Gregorius Soedharmo <arkatufus@yahoo.com>
Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Update framework targets and package versions

68ef99a

Signed-off-by: Gregorius Soedharmo <arkatufus@yahoo.com>


          Add xunit and Xunit.SkippableFact, replace [Test] with [SkippableFact]

b45555b


          Merge branch 'Update_to_Xunit' of github.com:Arkatufus/reactive-strea…

9c99de1

…ms-dotnet into Update_to_Xunit


          Update target frameworks

16412fd

Arkatufus closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet