Skip to content

feat(util): Allow conversion from StringBuf to string_view#299

Closed
bnbajwa wants to merge 1 commit intoreactivemarkets:masterfrom
bnbajwa:str
Closed

feat(util): Allow conversion from StringBuf to string_view#299
bnbajwa wants to merge 1 commit intoreactivemarkets:masterfrom
bnbajwa:str

Conversation

@bnbajwa
Copy link
Copy Markdown
Contributor

@bnbajwa bnbajwa commented Sep 11, 2025

SDB-9266

@bnbajwa bnbajwa requested a review from a team as a code owner September 11, 2025 15:01
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @bnbajwa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new conversion capability for the StringBuf utility class. By enabling explicit conversion to std::string_view, it facilitates more efficient and flexible string manipulation within the codebase, aligning StringBuf with contemporary C++ practices for non-owning string references.

Highlights

  • StringBuf to std::string_view Conversion: An explicit conversion operator has been added to the StringBuf class, allowing it to be directly converted to std::string_view. This enhances interoperability with modern C++ string handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an explicit conversion operator to std::string_view for the StringBuf class. The implementation is sound and correctly marked as explicit and noexcept. My feedback includes one suggestion to enhance it by making the operator constexpr, which would align it with other constexpr members of the class and improve its utility in compile-time contexts.

@bnbajwa bnbajwa enabled auto-merge (rebase) September 11, 2025 15:05
@bnbajwa bnbajwa disabled auto-merge September 11, 2025 15:23
@bnbajwa bnbajwa closed this Sep 11, 2025
@bnbajwa bnbajwa deleted the str branch November 4, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant