Skip to content

Conversation

@glennawatson
Copy link
Contributor

  • Cleanup editorconfig file, remove old settings, add description for each setting. Will be migrated to other repos in the future.
  • New AOT compatibility settings for non-test, non-WPF projects targeting .NET 8.0 and above in Directory.Build.props.
  • Enabled trim analyzers and set trimming warnings to be treated as errors.
  • Refactored NewGameViewModel to use a cryptographically secure random number generator for shuffling player order.
  • Improved readability by formatting code and adding a ShuffleCrypto method for better separation of concerns.
  • Minor documentation update in SuspensionHost.cs to improve clarity.

… each setting. Will be migrated to other repos in the future.

- New AOT compatibility settings for non-test, non-WPF projects targeting .NET 8.0 and above in Directory.Build.props.
- Enabled trim analyzers and set trimming warnings to be treated as errors.
- Refactored NewGameViewModel to use a cryptographically secure random number generator for shuffling player order.
- Improved readability by formatting code and adding a ShuffleCrypto method for better separation of concerns.
- Minor documentation update in SuspensionHost.cs to improve clarity.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request performs a comprehensive cleanup and modernization of the ReactiveUI codebase, focusing on configuration improvements, security enhancements, and documentation updates.

Key Changes:

  • Reorganized and enhanced the .editorconfig file with detailed categorization, comments, and expanded analyzer rules including comprehensive security rules
  • Added AOT (Ahead-of-Time) compatibility settings for .NET 8.0+ projects with trim analyzers enabled
  • Refactored NewGameViewModel to use cryptographically secure random number generation (RandomNumberGenerator) instead of the standard Random class

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.editorconfig Complete reorganization with categorized sections, descriptive comments for all rules, and extensive security analyzer configurations (CA series) covering SQL injection, XSS, deserialization, cryptography, TLS/SSL, and other security concerns
src/Directory.Build.props Added AOT compatibility settings for non-test, non-WPF projects targeting .NET 8.0+, including IsAotCompatible flag, trim analyzers, and treating trimming warnings as errors
src/ReactiveUI.Tests/ObservedChanged/Mocks/NewGameViewModel.cs Replaced insecure Random-based shuffling with Fisher-Yates shuffle using RandomNumberGenerator for cryptographic security; improved code formatting and separation of concerns with dedicated ShuffleCrypto method
src/ReactiveUI/Suspension/SuspensionHost.cs Removed cref tag from AutoSuspendHelper reference in documentation comment for clarity

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.75%. Comparing base (fe2a8c7) to head (5727d19).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4239      +/-   ##
==========================================
+ Coverage   40.33%   40.75%   +0.42%     
==========================================
  Files         146      146              
  Lines        6655     6655              
  Branches     1025     1025              
==========================================
+ Hits         2684     2712      +28     
+ Misses       3779     3745      -34     
- Partials      192      198       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glennawatson glennawatson requested a review from Copilot December 21, 2025 05:59
@glennawatson glennawatson changed the title Cleanup editorconfig file, remove old settings, minor other fixes. Cleanup editorconfig file, reorganise tests, other cleanup Dec 21, 2025
@glennawatson glennawatson changed the title Cleanup editorconfig file, reorganise tests, other cleanup chore: Cleanup editorconfig file, reorganise tests, other cleanup Dec 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 43 out of 317 changed files in this pull request and generated 6 comments.

glennawatson and others added 13 commits December 21, 2025 17:02
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pertyTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… add new tests for ViewLocator functionality.
Update project files to set OutputType to Exe for test projects and adjust package references
@glennawatson glennawatson requested a review from Copilot December 24, 2025 02:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 224 out of 494 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants