This repository was archived by the owner on Jul 19, 2019. It is now read-only.
[fixed] #42: add proper ARIA roles to elements#362
Open
ekim-novus wants to merge 5 commits intoreactjs:masterfrom
Open
[fixed] #42: add proper ARIA roles to elements#362ekim-novus wants to merge 5 commits intoreactjs:masterfrom
ekim-novus wants to merge 5 commits intoreactjs:masterfrom
Conversation
…apshot, update README, update example apps
|
👍 |
|
Looks good, we might not want to commit the build files though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the use of ARIA related to the
comboboxrole, following the guidelines here: https://www.w3.org/TR/wai-aria-1.1/#comboboxThis is for WCAG compliance.
Also updated README, example apps, and test snapshot.