This repository was archived by the owner on Jul 19, 2019. It is now read-only.
[added] Configurable autoHighlightValueMatches function#386
Closed
david-davidson wants to merge 1 commit intoreactjs:masterfrom
Closed
[added] Configurable autoHighlightValueMatches function#386david-davidson wants to merge 1 commit intoreactjs:masterfrom
autoHighlightValueMatches function#386david-davidson wants to merge 1 commit intoreactjs:masterfrom
Conversation
Author
|
Closing in favor of #387, which brings in the same change from a different branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, and thanks for this great library!
My team has an interesting use case. We're rendering a typeahead menu where the last item is always an entry to the effect of
"Don't see what you're looking for?". We're usingautoHighlight: trueto keep the first menu item highlighted. When the user types a string with no matches—say, "asasdfasdf"—the menu contains just the single"Don't see what you're looking for?"entry... but it's not highlighted (and therefore not selectable withEnter), because the logic for checking whether the first item should be highlighted assumes an exact string match at index 0.This PR adds a new
autoHighlightValueMatchesprop, allowing developers to override that logic. The prop is optional; if not provided, it defaults to the current behavior.I can think of a couple other possible use cases:
.includes()rather thanindexOf() === 0to determine match-iness.Please let me know if you have any questions here. Thank you!