Skip to content

Actualize sort-comp for supporting more selectors like static-variables, static-methods, getters, setters etc #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Actualize sort-comp for supporting more selectors like static-variables, static-methods, getters, setters etc #310

wants to merge 2 commits into from

Conversation

DmitryKorlas
Copy link

@DmitryKorlas DmitryKorlas commented Dec 2, 2022 •
edited
Loading

This PR implements a following "selectors" from react/sort-comp rule:

  • static-variables
  • static-methods
  • instance-variables
  • getters
  • setters
  • instance-methods

Also it fixes an issues of sorting, I covered it by tests to make sure it works well.

@stormwarning
Copy link

Any chance this could be merged? Having to manually patch this each time is kind of a pain 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryKorlas @stormwarning