Skip to content

Feature/verifier#46

Merged
jweiser merged 5 commits intomainfrom
feature/verifier
Dec 23, 2025
Merged

Feature/verifier#46
jweiser merged 5 commits intomainfrom
feature/verifier

Conversation

@jweiser
Copy link
Copy Markdown
Member

@jweiser jweiser commented Dec 21, 2025

adds code to verify a correct run of the "download-directory" release step

Also:

  • updates POM file to build main and verifier jars
  • updates Dockerfile to include verifier jar file in image build
  • updates Jenkinsfile to run verifier code after download-directory step completes

@jweiser jweiser self-assigned this Dec 21, 2025
@jweiser jweiser added the enhancement New feature or request label Dec 21, 2025
Copy link
Copy Markdown
Contributor

@adamjohnwright adamjohnwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, too. My only comment is that I have not maintained the spacing correctly by changing Jenkins files in the Jenkins GUI and in the GitHub GUI. Somehow it gets messed up in the browser. I noticed that you are changing where there are all spaces to tabs. I am happy with your default setting, but if there is a way in the repository to specify, for example, a certain number of spaces per tab and then check that all relevant files are formatted that way, that would be great. Probably shouldn't do it today, but something we could think about adding in the future.

@jweiser
Copy link
Copy Markdown
Member Author

jweiser commented Dec 23, 2025

This one looks good, too. My only comment is that I have not maintained the spacing correctly by changing Jenkins files in the Jenkins GUI and in the GitHub GUI. Somehow it gets messed up in the browser. I noticed that you are changing where there are all spaces to tabs. I am happy with your default setting, but if there is a way in the repository to specify, for example, a certain number of spaces per tab and then check that all relevant files are formatted that way, that would be great. Probably shouldn't do it today, but something we could think about adding in the future.

@adamjohnwright Thanks! I'm not committed to using spaces over tabs or vice-versa. As long as we're consistent. After doing some research, we could use a ".editorconfig" file (https://editorconfig.org/) for our repos then enact it using a repo-wide formatter and CI rules to apply and enforce the rules in commits.

@jweiser jweiser merged commit 9898aa6 into main Dec 23, 2025
2 checks passed
@jweiser jweiser deleted the feature/verifier branch December 23, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants