Conversation
|
Here are some stats for your PR:
Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=1558366701&job_ids[]=1543742924&selection=all |
There was a problem hiding this comment.
Hey, thanks a lot for this. I am looking forward to finally try it out for real.
I added some comments that you can consider if you like. One general comment: we have a clang-format post-commit hook and make a habit of just blindly following its suggested format. The PR seems to have some lines where the formatting is off. Maybe you did not have clang-format installed? The hook only applies to changed lines. So the trick (for retroactively fixing the formatting) is to soft-reset git and then create one commit for the whole change. At that point the pre-commit hook should automatically format all the changes. Let me know if you need any help with that.
| static unsigned oldSerializeChaos = false; | ||
| static bool oldDeoptChaos = false; | ||
|
|
||
| std::unordered_map<int, std::set<unsigned long>> conMap; |
There was a problem hiding this comment.
can you give this a more descriptive name and maybe a comment. I am not sure what it does
| } | ||
|
|
||
| bool startup() { | ||
| if (getenv("BLACKLIST") != NULL) { // load blacklisted contexts |
There was a problem hiding this comment.
would you mind calling this a blocklist instead?
There was a problem hiding this comment.
maybe add a small comment of what this list does?
| } | ||
| } | ||
|
|
||
| bool isBlacklisted(const Context & c) { |
There was a problem hiding this comment.
you could keep the list sorted, then you can abort the search once your entry is larger than the key?
| struct DispatchTable | ||
| : public RirRuntimeObject<DispatchTable, DISPATCH_TABLE_MAGIC> { | ||
|
|
||
| int hast; |
merge master
2 participants
No description provided.