Skip to content

Forward compatibility with react/promise 3 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Forward compatibility with react/promise 3 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"evenement/evenement": "^3.0 || ^2.0 || ^1.0",
"react/event-loop": "^1.2",
"react/dns": "^1.7",
"react/promise": "~2.1|~1.2"
"react/promise": "^3 || ^2.1 || ^1.2"
},
"require-dev": {
"clue/block-react": "~1.0",
Expand Down
3 changes: 1 addition & 2 deletions src/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use React\EventLoop\Loop;
use React\EventLoop\LoopInterface;
use React\Promise;
use React\Promise\CancellablePromiseInterface;
use \Exception;

class Factory
Expand Down Expand Up @@ -140,7 +139,7 @@ function ($_, $reject) use ($promise) {
$reject(new \RuntimeException('Cancelled creating socket during DNS lookup'));

// (try to) cancel pending DNS lookup, otherwise ignoring its results
if ($promise instanceof CancellablePromiseInterface) {
if (\method_exists($promise, 'cancel')) {
$promise->cancel();
}
}
Expand Down