fix(mdxish): set up default jsx context math operations to fix jsx not evaluated #1256
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinports
reviewed
Dec 23, 2025
| // These are not exhaustive, but are a good starting point | ||
| // We probably want to just use a library that'll load most of the common operations for us | ||
| export const DEFAULT_JSX_CONTEXT: JSXContext = { | ||
| uppercase: (value: string) => value.toUpperCase(), |
Contributor
There was a problem hiding this comment.
Struggling to understand why we're constructing a special context with these operations? If I understand correctly ES language features are already available when we eval the expressions. And I don't believe these functions are available in strict MDX so why/how would a user even know they exist?
Instead of Hello {uppercase("world")} I would instead write Hello {"world".toUpperCase()}
and instead of {add(1, 2)} I would write {1 + 2}
and so on...
Is there a requirement I'm missing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The default JSX context variable, which defined the mathematical operation functions for the JSX preprocessing step, accidentally got removed during the mdxish release😢, resulting in math operations in brackets not being operated. This PR adds it back, defining the common math operations for now, and added tests to the preprocessing step.
We would most likely want either to define more function operations (ideally importing from a library and not having to define & choose functions ourselves) in the future. But honestly I think it's also worth re-thinking how we want to store this context information
🧬 QA & Testing