fix(mdxish): fix rendering issues with Code magic blocks
#1259
+248
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We were seeing cases where magic blocks that uses the
codecases was wrapped in paragraph nodes which caused invalid HTML and values like props not being passed down correctly which resulting in errors and causing the page to not be renderable.CodeTabswere also being split into two components like this:This PR fixes this by detecting when code-tabs nodes are inserted into paragraphs and lifting them out to the root level, preventing the paragraph wrapper and ensuring props are passed correctly.
Note
The fix only affects code tabs, so other block-level elements (like tables) are unchanged.
🧬 QA & Testing
Use the attached md file in the linear ticket. Paste it into raw mode and make sure no errors are thrown.