fix(mdxish): fix rendering callout from magic blocks #1275
+83
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinports
approved these changes
Dec 23, 2025
Contributor
kevinports
left a comment
kevinports
left a comment
There was a problem hiding this comment.
Looks good to me. Noticed a few small things to be addressed but giving approval so this isn't blocked.
| const md = '[block:callout]{"type":"info","title":"Note","body":"This is important"}[/block]'; | ||
|
|
||
| const ast = mdxish(md); | ||
| console.log(JSON.stringify(ast, null, 2)); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log(JSON.stringify(ast, null, 2)); |
Comment on lines
+421
to
+424
| // Check if first child is a flow element that needs unwrapping (mdxJsxFlowElement, etc.) | ||
| const needsUnwrapping = (child: RootContent): boolean => { | ||
| return child.type === 'mdxJsxFlowElement'; | ||
| }; |
Contributor
There was a problem hiding this comment.
This could move out of the top visitor function so it is only created once.
| } | ||
| } | ||
| } else { | ||
| parent.children.splice(index, 1, ...children); |
Contributor
There was a problem hiding this comment.
Because we are mutating parent.children do we need to return an index of the next node to visit here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes an issue where callout magic blocks (
[block:callout]...[/block]) were not rendering correctly in the mdxish pipeline. The placeholder tokens (__MAGIC_BLOCK_0__) are parsed asinlineCodenodes, which can end up inside paragraphs. When magic blocks create flow elements (likemdxJsxFlowElement), they need to be unwrapped from the paragraph to maintain valid AST structure.Changes
mdxJsxFlowElementnodes directly with name'Callout'instead of intermediaterdme-calloutnodescalloutTransformerbehaviormdxJsxFlowElementnodes from paragraphs inmagicBlockRestorer, since flow elements cannot be children of paragraphs in MDASTBefore
Screen.Recording.2025-12-17.at.22.12.27.mov
After
Screen.Recording.2025-12-17.at.23.32.40.mov
🧬 QA & Testing