Add more infos to share template feature #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
force-pushed
the
add-more-infos-share-tpl
branch
from
245e799 to
bfc83f6
Compare
christophehenry
commented
Apr 13, 2025
Comment on lines
-59
to
-61
| exampleItem = if (database.itemDao().count() > 0) { | ||
| database.itemDao().selectFirst() | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
I'm just removing this. Event though using real data makes for a better UX generally speaking, querying an ItemWithFeed is just too difficult from here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #299 +/- ##
==========================================
Coverage 17.73% 17.73%
Complexity 460 460
==========================================
Files 190 190
Lines 10327 10326 -1
Branches 1611 1611
==========================================
Hits 1831 1831
+ Misses 8398 8397 -1
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
christophehenry
force-pushed
the
add-more-infos-share-tpl
branch
from
bfc83f6 to
bff3522
Compare
Member
|
LGTM! |
Contributor
Author
|
Hey @Shinokuni, unless I'm wrong, this, #287 and #259 haven't been published on F-droid yet, right? |
1 similar comment
Contributor
Author
|
Hey @Shinokuni, unless I'm wrong, this, #287 and #259 haven't been published on F-droid yet, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.