EthicalAd: fixed footer placement for specific themes #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a POC to show how we can use fixed footer ad on specific known themes. The logic is as follows: - the theme has to be a known theme - if the image ad added to the navbar has to be below the fold - show a fixed footer ad and we add some `padding-bottom` CSS style to the content container (theme-specific selector) with the height of the fixed footer ad (using fixed `47.2px` for now but it can be dynamically calculated) Closes #616
ericholscher
reviewed
Jul 7, 2025
There was a problem hiding this comment.
This looks great to me and what I was trying to do in a generic way that didn't work. I think applying it per theme will be a great test to see how it works on the CTR data. I can't speak too much to the CSS, and the right way to actually implement it, but it looks pretty simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC to show how we can use fixed footer ad on specific known themes. The logic is as follows:
padding-bottomCSS style to thecontent container (theme-specific selector) with the height of the fixed
footer ad (using fixed
47.2pxfor now but it can be dynamically calculated)The technique of adding the
padding-bottomto a theme-specific element solves the problem highlighted in the previous approach done in #447Sphinx Furo theme
Peek.2025-07-07.12-59.webm
Material for MkDocs
Peek.2025-07-07.13-10.webm
Closes #616