Publisher allowed domains #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step toward restricting which domains a publisher can show ads on. Right now, this just logs a message at warning if this setting is turned on (off by default). However, we have more and more publishers with 2 sites and I'd like to start being a bit more systematic there.
ericholscher
approved these changes
Apr 25, 2023
| _("Allowed domains"), | ||
| max_length=1024, | ||
| help_text=_( | ||
| "A space separated list of domains where the publisher's ads can appear" |
There was a problem hiding this comment.
Do we allow wildcards or similar here? Or is it a if in check or similar? Could be useful to be more specific so we know what to include, or is it an exact match?
There was a problem hiding this comment.
I think we may need those at some point. Before we implement it though, I'd like to know how common that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step toward restricting which domains a publisher can show ads on. Right now, this just logs a message at warning if this setting is turned on (off by default).
However, we have more and more publishers with 2 sites and I'd like to start being a bit more systematic there.
Ref: #194.