Skip to content

Conversation

@ericholscher
Copy link
Member

No description provided.

@read-the-docs-community
Copy link

Documentation build overview

📚 dev | 🛠️ Build #30077901 | 📁 Comparing a1dbb36 against latest (a60ef04)


🔍 Preview build

Show files changed (7 files in total): 📝 7 modified | ➕ 0 added | ➖ 0 deleted
File Status
aws-temporary-credentials.html 📝 modified
contribute.html 📝 modified
github-app.html 📝 modified
design/build-images.html 📝 modified
design/future-builder.html 📝 modified
design/new-notifications-system.html 📝 modified
design/secure-api-access-from-builders.html 📝 modified

@read-the-docs-community
Copy link

Documentation build overview

📚 docs | 🛠️ Build #30077902 | 📁 Comparing a1dbb36 against latest (a60ef04)


🔍 Preview build

Show files changed (14 files in total): 📝 14 modified | ➕ 0 added | ➖ 0 deleted
File Status
science.html 📝 modified
security-implications.html 📝 modified
security.html 📝 modified
commercial/sharing.html 📝 modified
config-file/v2.html 📝 modified
guides/build-troubleshooting.html 📝 modified
guides/connecting-git-account.html 📝 modified
guides/creating-project-private-repository.html 📝 modified
guides/deprecating-content.html 📝 modified
guides/private-python-packages.html 📝 modified
guides/reproducible-builds.html 📝 modified
guides/technical-docs-seo-guide.html 📝 modified
tutorial/index.html 📝 modified
guides/best-practice/links.html 📝 modified

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to merge main into you branch for tests to pass

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good.

Separate but we probably shouldn't host design docs in our public docs at all. Meta would be a good place for archiving and reviewing these. Design docs come up in searches -- ie this is the third hit for "github" query: https://docs.readthedocs.com/dev/stable/github-app.html


Since we are building a special cache for pre-compiled Python versions,
we could use the same method for all the other languages instead of creating a full mirror (many Gigabyes)
we could use the same method for all the other languages instead of creating a full mirror (many Gigabytes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
we could use the same method for all the other languages instead of creating a full mirror (many Gigabytes)
we could use the same method for all the other languages instead of creating a full mirror (many gigabytes)

@stsewd
Copy link
Member

stsewd commented Oct 28, 2025

the this is the third hit for "github" query:

that's mostly because we are now including subprojects by default in search results, design docs live in the dev docs.

@agjohnson
Copy link
Contributor

that's mostly because we are now including subprojects by default in search results, design docs live in the dev docs.

Aye, I knew they were coming from dev docs, I just don't think these should be in any of our public docs. These pages were more for our project planning and discussions than anything.

@ericholscher
Copy link
Member Author

Yea, I'm fine not rendering the design docs at all, and just keep them in GH.

@ericholscher ericholscher merged commit afac3f1 into main Nov 3, 2025
3 of 4 checks passed
@ericholscher ericholscher deleted the vale-updates branch November 3, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants