-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix vale issues #12532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vale issues #12532
Conversation
Documentation build overview
Show files changed (7 files in total): 📝 7 modified | ➕ 0 added | ➖ 0 deleted
|
Documentation build overview
Show files changed (14 files in total): 📝 14 modified | ➕ 0 added | ➖ 0 deleted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to merge main into you branch for tests to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good.
Separate but we probably shouldn't host design docs in our public docs at all. Meta would be a good place for archiving and reviewing these. Design docs come up in searches -- ie this is the third hit for "github" query: https://docs.readthedocs.com/dev/stable/github-app.html
|
|
||
| Since we are building a special cache for pre-compiled Python versions, | ||
| we could use the same method for all the other languages instead of creating a full mirror (many Gigabyes) | ||
| we could use the same method for all the other languages instead of creating a full mirror (many Gigabytes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| we could use the same method for all the other languages instead of creating a full mirror (many Gigabytes) | |
| we could use the same method for all the other languages instead of creating a full mirror (many gigabytes) |
that's mostly because we are now including subprojects by default in search results, design docs live in the dev docs. |
Aye, I knew they were coming from dev docs, I just don't think these should be in any of our public docs. These pages were more for our project planning and discussions than anything. |
|
Yea, I'm fine not rendering the design docs at all, and just keep them in GH. |
No description provided.