Set final cutoff date for projects using SSH keys with write access #12536
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the deprecation deadline for SSH keys with write access from July 31, 2025 to December 1st, 2025. This gives users additional time to migrate to read-only deploy keys before the hard enforcement begins.
- Updated user-facing messages across notification and error contexts to reflect the new December 1st, 2025 deadline
- Added hard failure logic that will enforce the deprecation after December 1st, 2025 when the brownout setting is enabled
- The enforcement involves raising a BuildUserError to stop builds that use SSH keys with write access
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| readthedocs/projects/notifications.py | Updated notification message deadline from July 31 to December 1st, 2025 |
| readthedocs/notifications/messages.py | Updated error message deadline from July 31 to December 1st, 2025 |
| readthedocs/doc_builder/director.py | Added hard failure enforcement logic with datetime check for December 1st, 2025 and updated import to include datetime module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses feedback from #12536 to use timezone-aware datetime objects in the SSH key write access deprecation check. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: