Fix wide response tables and Feishu cards#140
Merged
Conversation
Keep markdown tables constrained within assistant response cards and enable wide-screen Feishu markdown cards while ignoring local Claude artifacts. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR tightens UI layout constraints so assistant markdown (especially wide tables) stays contained within the chat column, and updates Feishu interactive cards to render in wide-screen mode.
Changes:
- Constrain response containers and markdown blocks to prevent wide content from expanding past the chat column.
- Improve table rendering so long/unbroken cell content can wrap while keeping table-level horizontal scrolling.
- Enable
wide_screen_modeon Feishu interactive markdown cards and update unit tests accordingly; ignore local.claude/artifacts via.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/components/SessionTurn.module.css |
Adds width constraints/overflow handling for response containers to keep content within the bubble/column. |
src/components/share/content-markdown.module.css |
Adjusts markdown/table CSS to avoid overflow and improve wrapping/scroll behavior for wide tables. |
electron/main/channels/feishu/feishu-transport.ts |
Adds config.wide_screen_mode: true when sending markdown via Feishu interactive cards. |
tests/unit/electron/channels/feishu/feishu-transport.test.ts |
Updates expectations to include the new Feishu card config. |
.gitignore |
Ignores .claude/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+37
to
41
| /** Send markdown wrapped in a Feishu Interactive Card with mobile-friendly configuration. */ | ||
| async sendMarkdown(chatId: string, markdown: string): Promise<string> { | ||
| const card = JSON.stringify({ | ||
| config: { wide_screen_mode: true }, | ||
| elements: [{ tag: "markdown", content: markdown }], |
There was a problem hiding this comment.
The doc comment says this card has “mobile-friendly configuration”, but the only config being set is wide_screen_mode: true, which is a wide-screen layout setting. Please update the comment to accurately describe what configuration is applied (or rename it if additional mobile-related config is intended).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/artifacts.Test plan
bun run test:unit tests/unit/electron/channels/feishu/feishu-transport.test.tsbun run typecheckcurrently fails on existingelectron/main/engines/opencode/converters.tstype errors unrelated to this change.🤖 Generated with Claude Code