Skip to content

Fix agent registration: add tx link + correct profile URL#153

Merged
realproject7 merged 1 commit intomainfrom
task/152-fix-agent-registration-links
Apr 24, 2026
Merged

Fix agent registration: add tx link + correct profile URL#153
realproject7 merged 1 commit intomainfrom
task/152-fix-agent-registration-links

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Show a BaseScan transaction link after successful ERC-8004 agent registration using the tx hash returned by the API
  • Fix "View agent profile" URL from /agents/{agentId} to /profile/{walletAddress}

Fixes #152

Test plan

  • Register a new agent and verify the BaseScan tx link appears and opens correctly
  • Verify the "View agent profile" link points to plotlink.xyz/profile/{walletAddress}
  • Verify existing registered agents still show profile link (no txHash = no tx link, which is expected)

🤖 Generated with Claude Code

- Store txHash from register-agent API response in linkStatus state
- Show BaseScan transaction link after successful ERC-8004 registration
- Fix profile URL from /agents/{id} to /profile/{walletAddress}

Fixes #152

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT

Summary

The change is minimal and aligns with issue #152: registration now surfaces a BaseScan tx link from the returned tx hash, and the profile link targets the wallet-based Plotlink URL.

Findings

  • [info] No code blockers found in the current diff. The tx link is gated on txHash, and the profile URL now uses owsWallet instead of the broken /agents/{id} path.
    • File: app/web/components/Settings.tsx:144
    • Suggestion: Post final approval after the current lint-and-typecheck run succeeds on this head commit.

Decision

Holding final approval until CI is green on the current revision.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The diff is minimal and correctly fixes both issue #152 regressions: it surfaces the BaseScan tx link after registration and points the profile link at the wallet-based Plotlink URL.

Findings

  • [info] No blocking issues found. txHash is captured from the registration response and rendered conditionally, and the profile URL now uses owsWallet instead of the broken /agents/{id} path.
    • File: app/web/components/Settings.tsx:144
    • Suggestion: None.

Decision

Approving because the implementation matches the acceptance criteria and lint-and-typecheck passed on the current head commit.

@realproject7 realproject7 merged commit 9419451 into main Apr 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Agent registration: missing tx link + wrong profile URL

2 participants