Skip to content

Fix genesis character limit from 1,000 to 10,000#167

Merged
realproject7 merged 2 commits intomainfrom
task/166-fix-genesis-char-limit
Apr 24, 2026
Merged

Fix genesis character limit from 1,000 to 10,000#167
realproject7 merged 2 commits intomainfrom
task/166-fix-genesis-char-limit

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Changes genesis charLimit from 1000 to 10000 to match the on-chain limit
  • Genesis and plot files now share the same 10,000-character limit

Fixes #166

Test plan

  • Open a genesis file with >1,000 but <10,000 characters — no "over limit" warning
  • Verify limit warning still appears for content >10,000 characters
  • Verify plot files still show 10,000 limit

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT

Summary

The diff matches issue #166 exactly: genesis now uses the real 10,000-character limit, consistent with plot files and the product behavior.

Findings

  • No code blockers found on the current diff.

Decision

Holding final approval until the current lint-and-typecheck run is green.

@realproject7
Copy link
Copy Markdown
Owner Author

@re2 Review — REQUEST CHANGES

The code fix is correct — combining isGenesis || isPlot into a single 10000 branch is clean and accurate. No other references to the old 1000 limit exist in the frontend.

🔴 Missing patch version bump

Per project rules, bug fixes should bump the patch version in package.json. Current main is 1.0.22 — this should go to 1.0.23.

One fix, then APPROVE.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@realproject7
Copy link
Copy Markdown
Owner Author

@re2 Re-review — APPROVE ✅

Version bumped to 1.0.23. Code fix unchanged and correct. No blockers.

APPROVE

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT

Summary

The latest head keeps the correct genesis-limit fix and adds the requested patch version bump to 1.0.23.

Findings

  • No remaining code blockers on the current diff.

Decision

Holding final approval until the current lint-and-typecheck run is green.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The current head fixes the genesis character-limit mismatch and keeps the related UI/versioning consistent. The diff remains minimal and matches issue #166.

Findings

  • No remaining blocking issues.

Decision

Approving because the implementation meets the acceptance criteria and lint-and-typecheck passed on the current head.

@realproject7 realproject7 merged commit 0bc89d5 into main Apr 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Genesis character limit shows 1,000 instead of 10,000

2 participants