[#93] Batch balanceOf with multicall in ReaderPortfolio#100
Merged
realproject7 merged 1 commit intomainfrom Mar 15, 2026
Merged
[#93] Batch balanceOf with multicall in ReaderPortfolio#100realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Replace N individual balanceOf RPC calls with a single multicall. Only fetch price/TVL data for tokens the user actually holds, reducing RPC overhead from O(N) to O(1) + O(held). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVE
Clean N+1 fix:
- All
balanceOfchecks batched into singlemulticall()✓ - Only fetches price/TVL for held tokens (non-zero balance) — reduces follow-up RPC calls too ✓
- Checks
balance.status === 'success'before accessing result ✓ - Early return for empty holdings ✓
LGTM ✓
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This replaces the O(N) per-token balanceOf loop in ReaderPortfolio with a single multicall batch and then limits follow-up pricing/TVL work to held tokens only, which matches issue #93 without broadening scope.
Findings
- No blocking findings.
Decision
Approving because the batching change is minimal, preserves existing downstream behavior for held tokens, and the refreshed lint/typecheck run passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #93
balanceOfRPC calls with a singlepublicClient.multicall()batchTest plan
🤖 Generated with Claude Code