[#91] Add prior activity threshold for rising algorithm#102
Merged
realproject7 merged 1 commit intomainfrom Mar 15, 2026
Merged
[#91] Add prior activity threshold for rising algorithm#102realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- Exclude storylines younger than 6 days (no prior window data) - Require at least 1 rating or 1 plot in the prior window to be eligible for rising, preventing new storylines with zero prior activity from inflating acceleration scores Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVE
Two-layer fix for rising score inflation:
- Age gate — excludes storylines younger than the 6-day prior window ✓
- Prior activity threshold — requires at least 1 rating or 1 plot in prior window, otherwise
trendScore: 0✓
Correctly scopes all downstream operations (onChainResults, enriched) to eligible instead of storylines.
LGTM ✓
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This change adds a meaningful baseline requirement for rising candidates by excluding storylines that are too new and those with no prior-window activity, which directly addresses the zero-history inflation described in issue #91.
Findings
- No blocking findings.
Decision
Approving because the eligibility threshold is minimal, matches the issue scope, and the refreshed lint/typecheck run passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #91
trendScore: 0, filtered out by the existing> 1checkTest plan
🤖 Generated with Claude Code