Skip to content

[#91] Add prior activity threshold for rising algorithm#102

Merged
realproject7 merged 1 commit intomainfrom
task/91-rising-threshold
Mar 15, 2026
Merged

[#91] Add prior activity threshold for rising algorithm#102
realproject7 merged 1 commit intomainfrom
task/91-rising-threshold

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

Fixes #91

  • Age gate: Storylines younger than 6 days (the prior window) are excluded from rising candidates — they have no meaningful baseline to compare against
  • Activity threshold: Storylines must have at least 1 rating or 1 plot in the prior window (days 3-6) to be eligible — prevents zero-denominator inflation
  • Storylines failing the activity check get trendScore: 0, filtered out by the existing > 1 check

Test plan

  • New storyline (< 6 days old) does not appear on rising tab
  • Storyline with no prior window activity does not appear on rising tab
  • Storyline with genuine acceleration (prior + recent activity) appears correctly
  • Rising tab returns empty when no storylines meet the threshold

🤖 Generated with Claude Code

- Exclude storylines younger than 6 days (no prior window data)
- Require at least 1 rating or 1 plot in the prior window to be
  eligible for rising, preventing new storylines with zero prior
  activity from inflating acceleration scores

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review — APPROVE

Two-layer fix for rising score inflation:

  1. Age gate — excludes storylines younger than the 6-day prior window ✓
  2. Prior activity threshold — requires at least 1 rating or 1 plot in prior window, otherwise trendScore: 0

Correctly scopes all downstream operations (onChainResults, enriched) to eligible instead of storylines.

LGTM ✓

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This change adds a meaningful baseline requirement for rising candidates by excluding storylines that are too new and those with no prior-window activity, which directly addresses the zero-history inflation described in issue #91.

Findings

  • No blocking findings.

Decision

Approving because the eligibility threshold is minimal, matches the issue scope, and the refreshed lint/typecheck run passed.

@realproject7 realproject7 merged commit 485afeb into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Rising algorithm inflates scores for new storylines with no prior history

2 participants