[#95] Add DB-level lowercase CHECK on rater_address#103
Merged
realproject7 merged 1 commit intomainfrom Mar 15, 2026
Merged
Conversation
Defense-in-depth: ensures rater_address is always lowercase at the DB level, preventing dedup issues if writes bypass the API's toLowerCase(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVE
Clean migration — single CHECK constraint enforcing rater_address = lower(rater_address). Correct defense-in-depth for address normalization.
Migration file naming follows existing convention (00006_ sequence). No application code changes needed.
LGTM ✓
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This adds the requested DB-level lowercase constraint on ratings.rater_address via a focused migration, which reinforces the existing API normalization and protects the unique dedup key from mixed-case writes.
Findings
- No blocking findings.
Decision
Approving because the migration matches issue #95, fits the current schema cleanly, and the refreshed lint/typecheck run passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #95
00006_ratings_address_check.sqlwith CHECK constraint:rater_address = lower(rater_address)Test plan
🤖 Generated with Claude Code