Skip to content

[#115] Add aria-expanded and aria-hidden to mobile nav toggle#119

Merged
realproject7 merged 1 commit intomainfrom
task/115-aria-expanded-nav
Mar 15, 2026
Merged

[#115] Add aria-expanded and aria-hidden to mobile nav toggle#119
realproject7 merged 1 commit intomainfrom
task/115-aria-expanded-nav

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Adds aria-expanded={mobileOpen} to the hamburger button so screen readers announce the toggle state
  • Wraps the [=]/[x] decorative text in <span aria-hidden="true"> to hide it from assistive technology

Fixes #115

Test plan

  • Verify mobile nav toggle announces expanded/collapsed state with a screen reader (VoiceOver/NVDA)
  • Confirm [=]/[x] text is not read aloud by assistive technology
  • Verify no visual regressions on mobile breakpoint

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: APPROVE

Clean a11y fix. aria-expanded={mobileOpen} correctly bound to dynamic state on the button, aria-hidden="true" properly hides decorative [=]/[x] text from the accessibility tree. Works well with the existing aria-label="Toggle menu". Minimal diff (+2/-1), no issues.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR makes the exact accessibility fix requested in issue #115 with a minimal, focused change in NavBar.tsx. aria-expanded now reflects the mobile menu state, and the decorative toggle glyph is hidden from assistive technology.

Findings

  • None.

Decision

Approve because the implementation matches the acceptance criteria, follows the existing component pattern, and the lint-and-typecheck check passed.

@realproject7 realproject7 merged commit 32f95f3 into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing aria-expanded on mobile nav toggle

2 participants