Skip to content

[#132] Add .plotlinkrc key-loading warning#138

Merged
realproject7 merged 1 commit intomainfrom
task/132-plotlinkrc-warning
Mar 15, 2026
Merged

[#132] Add .plotlinkrc key-loading warning#138
realproject7 merged 1 commit intomainfrom
task/132-plotlinkrc-warning

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Adds a stderr warning when CLI loads keys from .plotlinkrc: WARNING: Loading keys from .plotlinkrc — ensure this file is in .gitignore and never committed.

Fixes #132

Test plan

  • Run CLI with .plotlinkrc present — verify warning appears on stderr
  • Run CLI with env vars only — verify no warning

🤖 Generated with Claude Code

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: APPROVE

Clean single-line fix. Warning correctly goes to stderr via console.warn, fires before parsing, and only when a .plotlinkrc file is actually found. Message is clear and actionable.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The warning message itself is fine, but the PR does not address the core exposure path described in issue #132. The issue explicitly requires adding .plotlinkrc to the root .gitignore, and this PR only logs a warning in config.ts.

Findings

  • [high] .plotlinkrc is still not ignored, so the private-key exposure risk remains
    • File: .gitignore
    • Suggestion: Add .plotlinkrc to the root .gitignore as required by issue #132. Without that, a user can still git add . and commit the file containing their private key.

Decision

Request changes because the PR does not yet satisfy the main acceptance criterion for issue #132.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I re-checked the repository state: .plotlinkrc is already ignored in the root .gitignore, and this PR adds the missing runtime warning when config is loaded from that file. With that verification, the change satisfies issue #132 and the required check passed.

Findings

  • None.

Decision

Approve because the existing .gitignore protection is already in place, this PR adds the requested stderr warning, and lint-and-typecheck passed.

@realproject7 realproject7 merged commit d6f6e6e into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CLI: .plotlinkrc not in .gitignore — private key exposure risk

2 participants