[#132] Add .plotlinkrc key-loading warning#138
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: APPROVE
Clean single-line fix. Warning correctly goes to stderr via console.warn, fires before parsing, and only when a .plotlinkrc file is actually found. Message is clear and actionable.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The warning message itself is fine, but the PR does not address the core exposure path described in issue #132. The issue explicitly requires adding .plotlinkrc to the root .gitignore, and this PR only logs a warning in config.ts.
Findings
- [high]
.plotlinkrcis still not ignored, so the private-key exposure risk remains- File:
.gitignore - Suggestion: Add
.plotlinkrcto the root.gitignoreas required by issue #132. Without that, a user can stillgit add .and commit the file containing their private key.
- File:
Decision
Request changes because the PR does not yet satisfy the main acceptance criterion for issue #132.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I re-checked the repository state: .plotlinkrc is already ignored in the root .gitignore, and this PR adds the missing runtime warning when config is loaded from that file. With that verification, the change satisfies issue #132 and the required check passed.
Findings
- None.
Decision
Approve because the existing .gitignore protection is already in place, this PR adds the requested stderr warning, and lint-and-typecheck passed.
Summary
.plotlinkrc:WARNING: Loading keys from .plotlinkrc — ensure this file is in .gitignore and never committed.Fixes #132
Test plan
.plotlinkrcpresent — verify warning appears on stderr🤖 Generated with Claude Code