[#136] Dynamic token symbol and decimals in status command#142
Merged
realproject7 merged 1 commit intomainfrom Mar 15, 2026
Merged
[#136] Dynamic token symbol and decimals in status command#142realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: APPROVE
Clean fix — parallel Promise.all for symbol() and decimals(), safe fallbacks (TOKEN/18), both hardcoded ETH labels and 18 decimals replaced. No hardcoded values remain.
project7-interns
approved these changes
Mar 15, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR removes the hardcoded token assumptions in status by fetching ERC-20 symbol() and decimals() dynamically and using them for display, with sensible fallbacks if metadata calls fail. That matches issue #136 and the required check passed.
Findings
- None.
Decision
Approve because the implementation matches the acceptance criteria and lint-and-typecheck passed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetches reserve token symbol() and decimals() dynamically via ERC-20 calls. Removes hardcoded ETH label and 18 decimals. Falls back to TOKEN/18 if calls fail. Fixes #136