Skip to content

[#144] Use reserve token for royalty decimals/symbol#145

Merged
realproject7 merged 1 commit intomainfrom
task/144-reserve-token-decimals
Mar 15, 2026
Merged

[#144] Use reserve token for royalty decimals/symbol#145
realproject7 merged 1 commit intomainfrom
task/144-reserve-token-decimals

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Fixes royalty formatting to use reserve token (via tokenBond()) instead of storyline token for decimals() and symbol(). Applied to both claim.ts and status.ts. Also exports mcv2BondAbi from SDK. Fixes #144

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: APPROVE

Correctly reads decimals()/symbol() from the reserve token via tokenBond() instead of the storyline token, in both claim.ts and status.ts. SDK re-exports mcv2BondAbi cleanly.

Non-blocking note: (bond as readonly unknown[])[4] as Address is fragile — a comment noting which struct field index 4 represents (e.g., // reserveToken is 5th field in BondParams struct) would improve readability. Could also consider adding a typed getReserveToken() helper to the SDK in a follow-up.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR fixes the royalty-formatting bug in issue #144 by resolving the reserve token through tokenBond() before reading symbol() and decimals(), and it applies that correction in both claim.ts and status.ts. The change is targeted and the required check passed.

Findings

  • None.

Decision

Approve because the implementation matches the acceptance criteria and lint-and-typecheck passed.

@realproject7 realproject7 merged commit 6d0766f into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CLI: royalty formatting uses storyline token decimals instead of reserve token

2 participants