[#144] Use reserve token for royalty decimals/symbol#145
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: APPROVE
Correctly reads decimals()/symbol() from the reserve token via tokenBond() instead of the storyline token, in both claim.ts and status.ts. SDK re-exports mcv2BondAbi cleanly.
Non-blocking note: (bond as readonly unknown[])[4] as Address is fragile — a comment noting which struct field index 4 represents (e.g., // reserveToken is 5th field in BondParams struct) would improve readability. Could also consider adding a typed getReserveToken() helper to the SDK in a follow-up.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the royalty-formatting bug in issue #144 by resolving the reserve token through tokenBond() before reading symbol() and decimals(), and it applies that correction in both claim.ts and status.ts. The change is targeted and the required check passed.
Findings
- None.
Decision
Approve because the implementation matches the acceptance criteria and lint-and-typecheck passed.
Fixes royalty formatting to use reserve token (via tokenBond()) instead of storyline token for decimals() and symbol(). Applied to both claim.ts and status.ts. Also exports mcv2BondAbi from SDK. Fixes #144