Skip to content

[#152] Link tx hashes to block explorer#165

Merged
realproject7 merged 2 commits intomainfrom
task/152-tx-explorer-link
Mar 16, 2026
Merged

[#152] Link tx hashes to block explorer#165
realproject7 merged 2 commits intomainfrom
task/152-tx-explorer-link

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Added EXPLORER_URL constant to lib/contracts/constants.ts — testnet: sepolia.basescan.org, mainnet: basescan.org
  • Replaced all 4 plain-text tx hash displays with clickable <a> links to BaseScan
  • Updated: TradingWidget, DonateWidget, register-agent page (reg + bind tx hashes)

Fixes #152

Test plan

  • tsc --noEmit — zero errors
  • next build — clean
  • Complete a trade → tx hash is a clickable link opening BaseScan in new tab
  • Complete a donation → same
  • Register agent / bind wallet → same

🤖 Generated with Claude Code

Added EXPLORER_URL constant (testnet/mainnet aware) and replaced all
plain-text tx hash displays with clickable links to BaseScan. Updated
TradingWidget, DonateWidget, and register-agent page (4 occurrences).

Fixes #152

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Clean, minimal change. EXPLORER_URL constant is testnet/mainnet aware. All 4 tx hash displays (TradingWidget, DonateWidget, register-agent x2) consistently updated with target="_blank" and rel="noopener noreferrer". No issues.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The explorer-link implementation works for Trade, Donate, and register-agent, but PR #165 does not cover all transaction-result surfaces described in issue #152. The issue explicitly calls for updating every tx-hash display across the app, and there are still uncovered on-chain flows.

Findings

  • [medium] The PR leaves at least one transaction-result surface unchanged: the claim-royalties flow still completes without any explorer-linked tx hash, even though issue #152 explicitly lists src/components/ClaimRoyalties.tsx as affected.
    • File: src/components/ClaimRoyalties.tsx:46
    • Suggestion: Add tx-hash capture and explorer link rendering for the royalties claim flow, and do the same audit for the remaining publish/create flow before marking #152 fixed.

Decision

Requesting changes because the current PR only partially addresses issue #152. The new EXPLORER_URL constant is fine, but the rollout needs to cover the remaining tx-result UI surfaces called out in the issue before this can be approved.

Completes the audit — ClaimRoyalties now tracks and displays the
claim tx hash with a clickable BaseScan link. The create/publish
flow doesn't display tx hashes so no change needed there.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE (re-review after fix)

ClaimRoyalties now tracks txHash and renders the same explorer link pattern. All 5 tx-hash surfaces covered. Consistent implementation across the board.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up commit closes the rollout gap by adding the missing explorer-linked tx hash to ClaimRoyalties. The remaining tx-hash UI surfaces in issue #152 are now covered, and the updated head passes both GitHub CI and local validation.

Findings

  • [info] No remaining blocking findings after 8bef838.
    • File: src/components/ClaimRoyalties.tsx:112
    • Suggestion: None.

Decision

Approving because the prior coverage gap is resolved, the explorer-link behavior is now applied across the relevant transaction-result UI surfaces, and lint-and-typecheck plus local typecheck and build validation pass.

@realproject7 realproject7 merged commit d2a2129 into main Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Tx hash in Trade/Donate widgets should link to block explorer

2 participants