Skip to content

[#179] Replace optional 72h deadline with mandatory 7-day deadline#180

Merged
realproject7 merged 2 commits intomainfrom
task/179-mandatory-7day-deadline
Mar 16, 2026
Merged

[#179] Replace optional 72h deadline with mandatory 7-day deadline#180
realproject7 merged 2 commits intomainfrom
task/179-mandatory-7day-deadline

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Fixes #179 — DEADLINE_HOURS 72→168, removed checkbox, always hasDeadline=true, removed has_deadline guards.

- DEADLINE_HOURS: 72 → 168 in DeadlineCountdown and CLI status
- Create page: remove deadline checkbox, always pass hasDeadline=true
- SDK: default hasDeadline to true
- Writer dashboard + story page: remove has_deadline guards, always
  show countdown when last_plot_time exists and not sunset
- Add info text on create page about mandatory 7-day deadline

Fixes #179

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Clean, consistent change across all 6 files:

  1. DEADLINE_HOURS — 72→168 in both DeadlineCountdown and CLI status. Consistent.
  2. Create page — Checkbox removed, hasDeadline = true constant, info text added. Good simplification.
  3. SDK — Default flipped to true with updated JSDoc.
  4. Dashboard/story pagehas_deadline guards removed, countdown shows whenever last_plot_time exists and not sunset.

Net -14 lines. No issues.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The frontend/UI pieces are moving in the right direction, but the PR does not yet enforce the new mandatory-deadline policy across all creation paths. The CLI still exposes an optional deadline flag and passes its boolean directly into the SDK call, which means a caller can still create a storyline without a deadline.

Findings

  • [medium] The CLI create path still allows deadline-less storylines: --deadline remains optional with a default of false, and that value is passed straight into client.createStoryline(...). This violates the issue acceptance criterion that no code path allows storyline creation without a deadline.
    • File: packages/cli/src/commands/create.ts:12
    • Suggestion: Remove the CLI deadline flag entirely (or force it to true) and stop exposing hasDeadline as an externally controllable input for storyline creation.

Decision

Requesting changes because PR #180 does not yet make the 7-day deadline mandatory across all creation paths. The CLI path still permits false, so the policy change is incomplete.

Always pass hasDeadline=true — no opt-out path. Mandatory 7-day
deadline is now enforced across all creation surfaces.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up commit removes the remaining CLI opt-out path, so the mandatory 7-day deadline policy is now enforced consistently across web, SDK defaults, and CLI creation. The updated head passes both GitHub CI and local validation.

Findings

  • [info] No remaining blocking findings after 8f28b37.
    • File: packages/cli/src/commands/create.ts:12
    • Suggestion: None.

Decision

Approving because the prior policy-enforcement gap is resolved, no deadline-less creation path remains, and lint-and-typecheck plus local typecheck, test, and build validation pass.

@realproject7 realproject7 merged commit 0d47525 into main Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core] Replace optional 72h deadline with mandatory 7-day deadline

2 participants