[#179] Replace optional 72h deadline with mandatory 7-day deadline#180
[#179] Replace optional 72h deadline with mandatory 7-day deadline#180realproject7 merged 2 commits intomainfrom
Conversation
- DEADLINE_HOURS: 72 → 168 in DeadlineCountdown and CLI status - Create page: remove deadline checkbox, always pass hasDeadline=true - SDK: default hasDeadline to true - Writer dashboard + story page: remove has_deadline guards, always show countdown when last_plot_time exists and not sunset - Add info text on create page about mandatory 7-day deadline Fixes #179 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean, consistent change across all 6 files:
- DEADLINE_HOURS — 72→168 in both DeadlineCountdown and CLI status. Consistent.
- Create page — Checkbox removed,
hasDeadline = trueconstant, info text added. Good simplification. - SDK — Default flipped to
truewith updated JSDoc. - Dashboard/story page —
has_deadlineguards removed, countdown shows wheneverlast_plot_timeexists and not sunset.
Net -14 lines. No issues.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The frontend/UI pieces are moving in the right direction, but the PR does not yet enforce the new mandatory-deadline policy across all creation paths. The CLI still exposes an optional deadline flag and passes its boolean directly into the SDK call, which means a caller can still create a storyline without a deadline.
Findings
- [medium] The CLI create path still allows deadline-less storylines:
--deadlineremains optional with a default offalse, and that value is passed straight intoclient.createStoryline(...). This violates the issue acceptance criterion that no code path allows storyline creation without a deadline.- File:
packages/cli/src/commands/create.ts:12 - Suggestion: Remove the CLI deadline flag entirely (or force it to
true) and stop exposinghasDeadlineas an externally controllable input for storyline creation.
- File:
Decision
Requesting changes because PR #180 does not yet make the 7-day deadline mandatory across all creation paths. The CLI path still permits false, so the policy change is incomplete.
Always pass hasDeadline=true — no opt-out path. Mandatory 7-day deadline is now enforced across all creation surfaces. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit removes the remaining CLI opt-out path, so the mandatory 7-day deadline policy is now enforced consistently across web, SDK defaults, and CLI creation. The updated head passes both GitHub CI and local validation.
Findings
- [info] No remaining blocking findings after
8f28b37.- File:
packages/cli/src/commands/create.ts:12 - Suggestion: None.
- File:
Decision
Approving because the prior policy-enforcement gap is resolved, no deadline-less creation path remains, and lint-and-typecheck plus local typecheck, test, and build validation pass.
Fixes #179 — DEADLINE_HOURS 72→168, removed checkbox, always hasDeadline=true, removed has_deadline guards.