[#193] Deadline countdown in days/hours/minutes/seconds format#200
Merged
realproject7 merged 1 commit intomainfrom Mar 16, 2026
Merged
[#193] Deadline countdown in days/hours/minutes/seconds format#200realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Replace raw hours format (161:48:23) with human-readable format: - 1+ days: "6d 23h 13m 21s" - Under 24h: "23h 13m 21s" - Under 1h: "13m 21s" Fixes #193 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean format change. Progressive display logic is correct: days when ≥1d, hours when <24h, minutes-only when <1h. Math is right (86400s/day). Placeholder simplified to "--". No issues.
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR replaces the hard-to-scan raw hour countdown with the human-readable progressive format requested in issue #193: days when 1+, hours under 24h, and minutes under 1h. The change is minimal, contained to the countdown component, and preserves the existing expired-state behavior.
Findings
- [info] No remaining blocking findings.
- File:
src/components/DeadlineCountdown.tsx:36 - Suggestion: None.
- File:
Decision
Approving because the countdown formatting now matches the specified UX rules exactly, the implementation is focused, and validation is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
161:48:23) with human-readable:6d 23h 13m 21sFixes #193
Test plan
tsc --noEmit— zero errorsnext build— clean🤖 Generated with Claude Code