Skip to content

Fix ClaimRoyalties messaging: three states + tooltip#249

Merged
realproject7 merged 1 commit intomainfrom
task/248-fix-claim-royalties-messaging
Mar 17, 2026
Merged

Fix ClaimRoyalties messaging: three states + tooltip#249
realproject7 merged 1 commit intomainfrom
task/248-fix-claim-royalties-messaging

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Replace misleading "Chain X more plots to unlock royalties" with three distinct message states:
    1. plotCount < 2: "Chain at least 2 plots to enable royalty claims (X/2)"
    2. plotCount >= 2 and unclaimed == 0: "No royalties yet — royalties accrue when readers trade your token"
    3. plotCount >= 2 and unclaimed > 0: existing behavior (amount + enabled Claim button)
  • Update tooltip: strikethrough + checkmark on the plot requirement when met; clarify that royalties come from trades

Fixes #248

Test plan

  • Verify messaging with plotCount < 2 shows "Chain at least 2 plots to enable royalty claims (X/2)"
  • Verify messaging with plotCount >= 2 and no unclaimed shows "No royalties yet" message
  • Verify plotCount >= 2 and unclaimed > 0 shows amount + enabled Claim button (unchanged)
  • Verify tooltip shows strikethrough + checkmark when plot requirement met
  • npm run typecheck passes

🤖 Generated with Claude Code

… tooltip

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Clean, focused change. Three observations:

  1. Logic correct: The three states (!eligible, eligible && unclaimed === 0, eligible && unclaimed > 0) are mutually exclusive and exhaustive for txState === "idle" — no edge case gaps.

  2. Tooltip styling: line-through opacity-60 + checkmark on the plot requirement when met is a nice UX touch — makes progress visually clear at a glance.

  3. Copy improvement: "Royalties accrue when readers trade your token" is much more informative than the old "Unclaimed > 0" — users now understand why the balance might be zero.

No issues found. Typecheck passes per PR description.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR matches issue #248 and keeps the change narrowly scoped to ClaimRoyalties messaging. The new states remove the misleading unlock copy and add the missing eligible-but-zero explanation without changing claim behavior.

Findings

  • [info] No blocking issues found.

Decision

Approve. The three-state message logic and tooltip update are implemented as requested. CI was still pending when reviewed.

@realproject7 realproject7 merged commit dbaf629 into main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ClaimRoyalties messaging: stale plot count + misleading unlock message

2 participants