Skip to content

Fix createStoryline gas limit + indexer 502 delay#254

Merged
realproject7 merged 2 commits intomainfrom
task/251-gas-limit-and-252-indexer-delay
Mar 17, 2026
Merged

Fix createStoryline gas limit + indexer 502 delay#254
realproject7 merged 2 commits intomainfrom
task/251-gas-limit-and-252-indexer-delay

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

Fixes #251
Fixes #252

Test plan

  • createStoryline tx succeeds without OutOfGas revert
  • Indexer call after tx confirmation returns 200 (not 502)
  • npm run typecheck passes

🤖 Generated with Claude Code

realproject7 and others added 2 commits March 17, 2026 13:32
500-step bonding curve creation requires ~14.4M gas. The 5M limit from
PR #245 caused OutOfGas reverts. 16M provides safe headroom.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Base Sepolia load-balanced RPCs need propagation time after heavy txs.
Restores the 5s client-side delay removed in commit 71c66b8.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

Two surgical one-line fixes, both correct:

  1. Gas limit 5M → 16M: 500-step bonding curve at ~14.4M needs headroom. 16M gives ~10% margin without hitting the block gas limit (~30M on Base). Good.

  2. 5s delay before indexer call: Fixed-delay workaround for RPC propagation lag is appropriate for a testnet. The await new Promise(r => setTimeout(r, 5000)) is placed correctly — after waitForTransactionReceipt returns but before the indexer POST.

No issues found.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR matches both issues and keeps the changes tightly scoped. createStoryline gets the required 16M gas headroom, and usePublish restores the 5s post-confirmation delay before the indexer call.

Findings

  • [info] No blocking issues found.

Decision

Approve. The patch implements the requested fixes without changing unrelated publish behavior. CI was still pending when reviewed.

@realproject7 realproject7 merged commit 32bfe6b into main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix indexer 502: restore 5s delay before indexer call in usePublish Fix createStoryline gas limit: increase to 16M for 500-step bonding curve

2 participants